Bug 39633 - Inventory tool DataTable doesn't properly load
Summary: Inventory tool DataTable doesn't properly load
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-14 20:14 UTC by Lucas Gass (lukeg)
Modified: 2025-04-14 22:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39633: Use column names to get table settings (3.40 KB, patch)
2025-04-14 20:17 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-14 20:14:07 UTC
To recreate:

1. Cataloging > Inventory
2. Run the tool without uploaded barcodes 
3. Table loads and you see all the DataTable controls ( Table settings, etc )
4. Run the tool while uploading at least 1 barcode 
5. No DataTable controls 


This is because when we pass table settings through we don't know if the "Seen" column will who or not. It should use column names
Comment 1 Lucas Gass (lukeg) 2025-04-14 20:15:28 UTC
Also, when setting the default sort order we check `compareinv2barcd`. It should check uploadedbarcodesflag because the column only shows when when there is the uploadedbarcodesflag template variable
Comment 2 Lucas Gass (lukeg) 2025-04-14 20:17:12 UTC
Created attachment 180939 [details] [review]
Bug 39633: Use column names to get table settings

1. Cataloging > Inventory
2. Run the tool without uploaded barcodes
3. Table loads and you see all the DataTable controls ( Table settings, etc )
4. Run the tool while uploading at least 1 barcode
5. No DataTable controls
6. APPLY PATCH
7. Try steps 1 -4 again, making sure everything now works.