Summary: | Other holdings table paging numbers not correct initially | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | george, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 39634: Correct paging number on initial load of other_holdings table
Bug 39634: Correct paging number on initial load of other_holdings table Bug 39634: Correct paging number on initial load of other_holdings table |
Description
Lucas Gass (lukeg)
2025-04-14 22:33:19 UTC
Created attachment 180945 [details] [review] Bug 39634: Correct paging number on initial load of other_holdings table To test: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. 7. APPLY PATCH 8. Try again, this time the paging numbers should be correct initially. Created attachment 180946 [details] [review] Bug 39634: Correct paging number on initial load of other_holdings table To test: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. 7. APPLY PATCH 8. Try again, this time the paging numbers should be correct initially. I tried to sign off at https://staff-tabs.sandboxes.ptfs-europe.co.uk but after I applied the patch there was no content on both #holdings_table and #otherholdings_table. I tried restarting services but the tables wouldn't load at all. Created attachment 180990 [details] [review] Bug 39634: Correct paging number on initial load of other_holdings table To test: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. 7. APPLY PATCH 8. Try again, this time the paging numbers should be correct initially. Signed-off-by: George Williams <george@nekls.org> Worked on second try. Thanks for the patch. Not sure why but I am seeing the damaged_on column, I am expecting it to be hidden by default. Hum, cannot we achieve that without a redraw? I don't understand why this is happening, can you provide more detail, Lucas? I downloaded the new version of DataTables: https://datatables.net/download/#dt/jszip-3.10.1/pdfmake-0.2.7/dt-2.1.8/b-3.1.2/b-colvis-3.1.2/b-html5-3.1.2/b-print-3.1.2/fh-4.0.1/r-3.0.3/rg-1.5.0/rr-1.5.0 And the problem is fixed. But we have local customization, so it's not that easy to update. The problem is either coming from our version of DataTables, or our local customization. |