Bug 39634 - Other holdings table paging numbers not correct initially
Summary: Other holdings table paging numbers not correct initially
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-14 22:33 UTC by Lucas Gass (lukeg)
Modified: 2025-05-13 19:54 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39634: Correct paging number on initial load of other_holdings table (2.47 KB, patch)
2025-04-14 22:35 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39634: Correct paging number on initial load of other_holdings table (2.14 KB, patch)
2025-04-14 22:37 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39634: Correct paging number on initial load of other_holdings table (2.19 KB, patch)
2025-04-15 19:24 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-14 22:33:19 UTC
To recreate:

1. Turn on SeparateHoldings
2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL.
3. Logged in as CPL go to the record in normal view. 
4. Click on the 'Other holdings' tab, which should have 50+ items 
5. Notice you only see the number 1 in the paging tools.
6. Click 'Next', the paging numbers correct themselves. 

This problem only happens when you initially tab over to the other holdings table.
Comment 1 Lucas Gass (lukeg) 2025-04-14 22:35:02 UTC
Created attachment 180945 [details] [review]
Bug 39634: Correct paging number on initial load of other_holdings table

To test:
1. Turn on SeparateHoldings
2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL.
3. Logged in as CPL go to the record in normal view.
4. Click on the 'Other holdings' tab, which should have 50+ items
5. Notice you only see the number 1 in the paging tools.
6. Click 'Next', the paging numbers correct themselves.
7. APPLY PATCH
8. Try again, this time the paging numbers should be correct initially.
Comment 2 Lucas Gass (lukeg) 2025-04-14 22:37:54 UTC
Created attachment 180946 [details] [review]
Bug 39634: Correct paging number on initial load of other_holdings table

To test:
1. Turn on SeparateHoldings
2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL.
3. Logged in as CPL go to the record in normal view.
4. Click on the 'Other holdings' tab, which should have 50+ items
5. Notice you only see the number 1 in the paging tools.
6. Click 'Next', the paging numbers correct themselves.
7. APPLY PATCH
8. Try again, this time the paging numbers should be correct initially.
Comment 3 George Williams (NEKLS) 2025-04-15 00:28:09 UTC
I tried to sign off at https://staff-tabs.sandboxes.ptfs-europe.co.uk but after I applied the patch there was no content on both #holdings_table and #otherholdings_table.  I tried restarting services but the tables wouldn't load at all.
Comment 4 PTFS Europe Sandboxes 2025-04-15 19:24:02 UTC
Created attachment 180990 [details] [review]
Bug 39634: Correct paging number on initial load of other_holdings table

To test:
1. Turn on SeparateHoldings
2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL.
3. Logged in as CPL go to the record in normal view.
4. Click on the 'Other holdings' tab, which should have 50+ items
5. Notice you only see the number 1 in the paging tools.
6. Click 'Next', the paging numbers correct themselves.
7. APPLY PATCH
8. Try again, this time the paging numbers should be correct initially.

Signed-off-by: George Williams <george@nekls.org>
Comment 5 George Williams (NEKLS) 2025-04-15 19:24:34 UTC
Worked on second try.  Thanks for the patch.
Comment 6 Jonathan Druart 2025-05-13 13:24:01 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2025-05-13 13:28:13 UTC
Hum, cannot we achieve that without a redraw?
Comment 8 Jonathan Druart 2025-05-13 13:29:42 UTC
I don't understand why this is happening, can you provide more detail, Lucas?
Comment 9 Jonathan Druart 2025-05-13 19:54:47 UTC
I downloaded the new version of DataTables: https://datatables.net/download/#dt/jszip-3.10.1/pdfmake-0.2.7/dt-2.1.8/b-3.1.2/b-colvis-3.1.2/b-html5-3.1.2/b-print-3.1.2/fh-4.0.1/r-3.0.3/rg-1.5.0/rr-1.5.0

And the problem is fixed.

But we have local customization, so it's not that easy to update.

The problem is either coming from our version of DataTables, or our local customization.