| Summary: | Repeatable AV additional fields no longer work | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, martin.renvoize, michaela.sieber, paul.derscheid, pedro.amorim |
| Version: | Main | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 38714 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 39664: Fix selection of repeatable additional fields linked with AV
Bug 39664: Fix selection of repeatable additional fields linked with AV Bug 39664: Fix selection of repeatable additional fields linked with AV |
||
|
Description
Pedro Amorim
2025-04-17 09:04:10 UTC
Created attachment 181245 [details] [review] Bug 39664: Fix selection of repeatable additional fields linked with AV Move the radio buttons outside of the select. Caused by commit ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3 Bug 38714: additional-fields-entry.inc To test: 1) Add an AV 'repeatable' additional field for libraries, at: http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Edit a library. Notice no options show. 3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show. Created attachment 181260 [details] [review] Bug 39664: Fix selection of repeatable additional fields linked with AV Move the radio buttons outside of the select. Caused by commit ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3 Bug 38714: additional-fields-entry.inc To test: 1) Add an AV 'repeatable' additional field for libraries, at: http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Edit a library. Notice no options show. 3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Created attachment 181262 [details] [review] Bug 39664: Fix selection of repeatable additional fields linked with AV Move the radio buttons outside of the select. Caused by commit ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3 Bug 38714: additional-fields-entry.inc To test: 1) Add an AV 'repeatable' additional field for libraries, at: http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Edit a library. Notice no options show. 3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Pushed for 25.05! Well done everyone, thank you! Backport depends on Bug 38714 comment 11 Problem does not appear in 24.11.x Bug 38714 is not applied on additional-fields-entry.inc This is a bug fix/regression fix, nothing to change in the manual. |