Bug 39664 - Repeatable AV additional fields no longer work
Summary: Repeatable AV additional fields no longer work
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: regression
Depends on: 38714
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-17 09:04 UTC by Pedro Amorim
Modified: 2025-04-25 18:10 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39664: Fix selection of repeatable additional fields linked with AV (5.07 KB, patch)
2025-04-22 11:14 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39664: Fix selection of repeatable additional fields linked with AV (5.13 KB, patch)
2025-04-22 12:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 39664: Fix selection of repeatable additional fields linked with AV (5.19 KB, patch)
2025-04-22 13:54 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-04-17 09:04:10 UTC
Caused by:
https://github.com/Koha-Community/Koha/commit/ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3

To test:
1) Add an AV 'repeatable' additional field for libraries, at:
http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches
2) Edit a library. Notice no options show.
3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show.
Comment 1 Jonathan Druart 2025-04-22 11:14:44 UTC
Created attachment 181245 [details] [review]
Bug 39664: Fix selection of repeatable additional fields linked with AV

Move the radio buttons outside of the select.

Caused by
  commit ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3
  Bug 38714: additional-fields-entry.inc

To test:
1) Add an AV 'repeatable' additional field for libraries, at:
http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches
2) Edit a library. Notice no options show.
3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show.
Comment 2 Pedro Amorim 2025-04-22 12:55:35 UTC
Created attachment 181260 [details] [review]
Bug 39664: Fix selection of repeatable additional fields linked with AV

Move the radio buttons outside of the select.

Caused by
  commit ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3
  Bug 38714: additional-fields-entry.inc

To test:
1) Add an AV 'repeatable' additional field for libraries, at:
http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches
2) Edit a library. Notice no options show.
3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show.

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 3 Martin Renvoize (ashimema) 2025-04-22 13:54:10 UTC
Created attachment 181262 [details] [review]
Bug 39664: Fix selection of repeatable additional fields linked with AV

Move the radio buttons outside of the select.

Caused by
  commit ba31ec291f5cbb6a0a8edd7e66934127a3f6a8a3
  Bug 38714: additional-fields-entry.inc

To test:
1) Add an AV 'repeatable' additional field for libraries, at:
http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl?tablename=branches
2) Edit a library. Notice no options show.
3) Revert additional-fields-entry.inc to how it was previous to the commit. Hard refresh the edit library page. Notice the options show.

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Katrin Fischer 2025-04-23 07:43:28 UTC
Pushed for 25.05!

Well done everyone, thank you!