Summary: | Add the role presentation to the vertical divider in the navigation | ||
---|---|---|---|
Product: | Koha | Reporter: | Nina Martinez <nina.martinez> |
Component: | Accessibility | Assignee: | Nina Martinez <nina.martinez> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, julian.maurice, lucas, martin.renvoize, matt.blenkinsop, oleonard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 23003 | ||
Attachments: |
Bug 39677: Add the role presentation to the divider vertical tags
Bug 39677: Add the role presentation to the divider vertical tags Bug 39677: Add the role presentation to the divider vertical tags Bug 39677: Add the role presentation to the divider vertical tags |
Description
Nina Martinez
2025-04-18 13:22:36 UTC
Created attachment 181239 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Created attachment 181432 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). - Apply the patch. - Go to the Koha OPAC. - Check the vertical dividers in the navigation. - If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 181565 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). - Apply the patch. - Go to the Koha OPAC. - Check the vertical dividers in the navigation. - If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> I added my sign off, in case Owen's can count as QA. However, running the QA script generates errors, but that may be because of something wrong my setup: qa testing 1 commit(s) (applied to 9640d5d '38 Bug 38842: (follow-up) Fix TT filt') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches [error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112. [error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112. FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc` FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc` Processing additional checks OK! * Was this bug sponsored by anyone? Something in main is not right - that will cause the errors you see. Needs a rebase Created attachment 182248 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> |