Summary: | Low contrast for claim return date in circulation overdue report | ||
---|---|---|---|
Product: | Koha | Reporter: | Laura Escamilla <Laura.escamilla> |
Component: | Circulation | Assignee: | Laura Escamilla <Laura.escamilla> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, gmcharlt, kyle.m.hall, martin.renvoize, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the color of the date in the return claims column on the overdues page (Circulation > Overdues > Overdues) - the date is now shown in black, instead of white.
Previously, the date shown after a claim returned action is completed was white. The date not visible in rows with a white background, and was almost invisible in rows with a grey background.
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 39696: Enhanced text contrast by changing it to black
Bug 39696: Enhanced text contrast by changing it to black Bug 39696: (Alternative) Set text-bg-info on badge Bug 39696: (Alternative follow-up) Set text-bg-info on badge Bug 39696: (Alternative) Set text-bg-info on badge Bug 39696: (Alternative follow-up) Set text-bg-info on badge Bug 39696: Set text-bg-info on badge Bug 39696: (follow-up) Set text-bg-info on badge |
Description
Laura Escamilla
2025-04-22 12:27:27 UTC
Created attachment 181261 [details] [review] Bug 39696: Enhanced text contrast by changing it to black Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Yarn build 8. Clear cache in browser and observe the display: the claim return date text is now #000 (black). 9. Sign off and have an amazing day! :D Created attachment 181569 [details] [review] Bug 39696: Enhanced text contrast by changing it to black Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Yarn build 8. Clear cache in browser and observe the display: the claim return date text is now #000 (black). 9. Sign off and have an amazing day! :D Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Step 3: Circulation > Overdues > Overdues. 2. Step 5: Even though the table cell under the "Return claims" column looks empty, use your mouse to select the text in the cell (for mouse users). I will now have an amazing day! 8-) I'm not so sure about this change, it affects ALL badges and could well be making other badges of different colors worse to make this one better. Created attachment 182085 [details] [review] Bug 39696: (Alternative) Set text-bg-info on badge With bootstrap 5, a 'badge' class should always be accompanied by a text-bg-# class. This second class sets the badge color and an appropriate forground text color to ensure appropriate contrast. Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows andi has poor contrast on grey rows. 6. Apply the patch 7. Clear cache in browser and observe the display: the claim return date badge is now blue with black text. 8. Sign off and have an amazing day! :D Created attachment 182086 [details] [review] Bug 39696: (Alternative follow-up) Set text-bg-info on badge We also use a badge without a text-bg-# class on the modal claims include.. this patch adds the same text-bg-info to that. (In reply to Martin Renvoize (ashimema) from comment #4) > I'm not so sure about this change, it affects ALL badges and could well be > making other badges of different colors worse to make this one better. Added Owen to get his input on the changes. Created attachment 182163 [details] [review] Bug 39696: (Alternative) Set text-bg-info on badge With bootstrap 5, a 'badge' class should always be accompanied by a text-bg-# class. This second class sets the badge color and an appropriate forground text color to ensure appropriate contrast. Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Clear cache in browser and observe the display: the claim return date badge is now blue with black text. 8. Sign off and have an amazing day! :D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 182164 [details] [review] Bug 39696: (Alternative follow-up) Set text-bg-info on badge We also use a badge without a text-bg-# class on the modal claims include.. this patch adds the same text-bg-info to that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I've added some info to the wiki on Bootstrap color classes: https://wiki.koha-community.org/wiki/Bootstrap#Colors Created attachment 182178 [details] [review] Bug 39696: Set text-bg-info on badge With bootstrap 5, a 'badge' class should always be accompanied by a text-bg-# class. This second class sets the badge color and an appropriate forground text color to ensure appropriate contrast. Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Clear cache in browser and observe the display: the claim return date badge is now blue with black text. 8. Sign off and have an amazing day! :D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 182179 [details] [review] Bug 39696: (follow-up) Set text-bg-info on badge We also use a badge without a text-bg-# class on the modal claims include.. this patch adds the same text-bg-info to that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Pushed for 25.05! Well done everyone, thank you! |