Bug 39696 - Low contrast for claim return date in circulation overdue report
Summary: Low contrast for claim return date in circulation overdue report
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Laura Escamilla
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-22 12:27 UTC by Laura Escamilla
Modified: 2025-05-12 16:32 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the color of the date in the return claims column on the overdues page (Circulation > Overdues > Overdues) - the date is now shown in black, instead of white. Previously, the date shown after a claim returned action is completed was white. The date not visible in rows with a white background, and was almost invisible in rows with a grey background.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39696: Enhanced text contrast by changing it to black (1.71 KB, patch)
2025-04-22 13:06 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 39696: Enhanced text contrast by changing it to black (1.76 KB, patch)
2025-04-26 19:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 39696: (Alternative) Set text-bg-info on badge (2.38 KB, patch)
2025-05-08 13:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39696: (Alternative follow-up) Set text-bg-info on badge (1.19 KB, patch)
2025-05-08 13:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39696: (Alternative) Set text-bg-info on badge (2.44 KB, patch)
2025-05-09 11:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39696: (Alternative follow-up) Set text-bg-info on badge (1.24 KB, patch)
2025-05-09 11:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39696: Set text-bg-info on badge (2.49 KB, patch)
2025-05-09 14:15 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39696: (follow-up) Set text-bg-info on badge (1.29 KB, patch)
2025-05-09 14:15 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2025-04-22 12:27:27 UTC
Steps to Reproduce:
1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference.
2. Check out an item to a patron, and backdate the due date so that it becomes overdue.
3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item.
4. Mark the item as "Claims Returned".
5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows.
Comment 1 Laura Escamilla 2025-04-22 13:06:33 UTC Comment hidden (obsolete)
Comment 2 David Nind 2025-04-26 19:38:46 UTC Comment hidden (obsolete)
Comment 3 David Nind 2025-04-26 19:47:13 UTC
Testing notes (using KTD):
1. Step 3: Circulation > Overdues > Overdues.
2. Step 5: Even though the table cell under the "Return claims" column looks empty, use your mouse to select the text in the cell (for mouse users). 

I will now have an amazing day! 8-)
Comment 4 Martin Renvoize (ashimema) 2025-05-08 13:21:36 UTC
I'm not so sure about this change, it affects ALL badges and could well be making other badges of different colors worse to make this one better.
Comment 5 Martin Renvoize (ashimema) 2025-05-08 13:32:39 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize (ashimema) 2025-05-08 13:35:40 UTC Comment hidden (obsolete)
Comment 7 David Nind 2025-05-08 20:32:54 UTC
(In reply to Martin Renvoize (ashimema) from comment #4)
> I'm not so sure about this change, it affects ALL badges and could well be
> making other badges of different colors worse to make this one better.

Added Owen to get his input on the changes.
Comment 8 Owen Leonard 2025-05-09 11:37:29 UTC
Created attachment 182163 [details] [review]
Bug 39696: (Alternative) Set text-bg-info on badge

With bootstrap 5, a 'badge' class should always be accompanied by a
text-bg-# class. This second class sets the badge color and an
appropriate forground text color to ensure appropriate contrast.

Steps to test:
1. Enable the ability to mark items as "Claimed Returned" by setting
   the ClaimReturnedLostValue system preference.
2. Check out an item to a patron, and backdate the due date so that it
   becomes overdue.
3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item.
4. Mark the item as "Claims Returned".
5. Observe the display: the claim return date text uses #fff (white),
   which is not visible on white table rows and has poor contrast on
   grey rows.
6. Apply the patch
7. Clear cache in browser and observe the display: the claim return date
   badge is now blue with black text.
8. Sign off and have an amazing day! :D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Owen Leonard 2025-05-09 11:37:32 UTC
Created attachment 182164 [details] [review]
Bug 39696: (Alternative follow-up) Set text-bg-info on badge

We also use a badge without a text-bg-# class on the modal claims
include.. this patch adds the same text-bg-info to that.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 10 Owen Leonard 2025-05-09 11:39:20 UTC
I've added some info to the wiki on Bootstrap color classes:
https://wiki.koha-community.org/wiki/Bootstrap#Colors
Comment 11 Martin Renvoize (ashimema) 2025-05-09 14:15:25 UTC
Created attachment 182178 [details] [review]
Bug 39696: Set text-bg-info on badge

With bootstrap 5, a 'badge' class should always be accompanied by a
text-bg-# class. This second class sets the badge color and an
appropriate forground text color to ensure appropriate contrast.

Steps to test:
1. Enable the ability to mark items as "Claimed Returned" by setting
   the ClaimReturnedLostValue system preference.
2. Check out an item to a patron, and backdate the due date so that it
   becomes overdue.
3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item.
4. Mark the item as "Claims Returned".
5. Observe the display: the claim return date text uses #fff (white),
   which is not visible on white table rows and has poor contrast on
   grey rows.
6. Apply the patch
7. Clear cache in browser and observe the display: the claim return date
   badge is now blue with black text.
8. Sign off and have an amazing day! :D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 12 Martin Renvoize (ashimema) 2025-05-09 14:15:28 UTC
Created attachment 182179 [details] [review]
Bug 39696: (follow-up) Set text-bg-info on badge

We also use a badge without a text-bg-# class on the modal claims
include.. this patch adds the same text-bg-info to that.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 13 Katrin Fischer 2025-05-12 16:32:37 UTC
Pushed for 25.05!

Well done everyone, thank you!