Bug 39707

Summary: Fix JS error when placing a request
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: OPACAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: major    
Priority: P5 - low CC: lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 36081    
Bug Blocks:    
Attachments: Bug 39707: Fix JS error when requesting an article - OPAC
Bug 39707: Fix JS error when requesting an article - OPAC
Bug 39707: Fix JS error when requesting an article - OPAC

Description Jonathan Druart 2025-04-23 08:36:42 UTC
Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list
Comment 1 Jonathan Druart 2025-04-23 08:37:45 UTC
Created attachment 181347 [details] [review]
Bug 39707: Fix JS error when requesting an article - OPAC

Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list
Comment 2 Katrin Fischer 2025-04-23 11:08:29 UTC
If it's just the ) I'll grab this out of the list for next push (and test), OK?
Comment 3 Jonathan Druart 2025-04-23 11:35:40 UTC
it's not only the parenthesis, also duplicated code that is removed.
Comment 4 Katrin Fischer 2025-04-23 11:37:42 UTC
OK, let's have an additional set of eyes then.
Comment 5 Marcel de Rooy 2025-04-23 14:27:15 UTC
Created attachment 181379 [details] [review]
Bug 39707: Fix JS error when requesting an article - OPAC

Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Lucas Gass (lukeg) 2025-04-29 15:42:50 UTC
Created attachment 181673 [details] [review]
Bug 39707: Fix JS error when requesting an article - OPAC

Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Katrin Fischer 2025-05-02 06:55:24 UTC
Pushed for 25.05!

Well done everyone, thank you!