Bug 39707 - Fix JS error when placing a request
Summary: Fix JS error when placing a request
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 36081
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-23 08:36 UTC by Jonathan Druart
Modified: 2025-05-02 06:55 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39707: Fix JS error when requesting an article - OPAC (4.04 KB, patch)
2025-04-23 08:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39707: Fix JS error when requesting an article - OPAC (4.14 KB, patch)
2025-04-23 14:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 39707: Fix JS error when requesting an article - OPAC (4.16 KB, patch)
2025-04-29 15:42 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-04-23 08:36:42 UTC
Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list
Comment 1 Jonathan Druart 2025-04-23 08:37:45 UTC
Created attachment 181347 [details] [review]
Bug 39707: Fix JS error when requesting an article - OPAC

Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list
Comment 2 Katrin Fischer 2025-04-23 11:08:29 UTC
If it's just the ) I'll grab this out of the list for next push (and test), OK?
Comment 3 Jonathan Druart 2025-04-23 11:35:40 UTC
it's not only the parenthesis, also duplicated code that is removed.
Comment 4 Katrin Fischer 2025-04-23 11:37:42 UTC
OK, let's have an additional set of eyes then.
Comment 5 Marcel de Rooy 2025-04-23 14:27:15 UTC
Created attachment 181379 [details] [review]
Bug 39707: Fix JS error when requesting an article - OPAC

Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Lucas Gass (lukeg) 2025-04-29 15:42:50 UTC
Created attachment 181673 [details] [review]
Bug 39707: Fix JS error when requesting an article - OPAC

Caused by a bad conflict resolution when bug 36081 was pushed

Uncaught SyntaxError: missing ) after argument list

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Katrin Fischer 2025-05-02 06:55:24 UTC
Pushed for 25.05!

Well done everyone, thank you!