Bug 39746

Summary: Wrong system preference 'AutoLocation' in test suite
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Test SuiteAssignee: Fridolin Somers <fridolin.somers>
Status: Pushed to main --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 36944, 26176    
Bug Blocks: 39720    
Attachments: Bug 39746: Wrong system preference 'AutoLocation' in test suite
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite

Description Fridolin Somers 2025-04-25 09:18:08 UTC
Bug 26176 renamed AutoLocation to StaffLoginRestrictBranchByIP
Needs to be fixed in test suite
Comment 1 Fridolin Somers 2025-04-25 09:24:13 UTC
(In reply to Fridolin Somers from comment #0)
> Bug 26176 renamed AutoLocation to StaffLoginRestrictBranchByIP
> Needs to be fixed in test suite

StaffLoginRestrictBranchByIP is actually StaffLoginRestrictLibraryByIP
Comment 2 Fridolin Somers 2025-04-25 09:26:51 UTC
Created attachment 181495 [details] [review]
Bug 39746: Wrong system preference 'AutoLocation' in test suite

Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'
Needs to be fixed in test suite

Test plan:
Enable 'StaffLoginRestrictLibraryByIP' in prefs
Run : prove Auth.t
Should pass
Comment 3 Fridolin Somers 2025-04-25 09:37:52 UTC
Created attachment 181497 [details] [review]
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite

Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'
Needs to be fixed in test suite

Test plan:
Enable 'StaffLoginRestrictLibraryByIP' in prefs
Run : prove Auth.t
Should pass
Comment 4 Roman Dolny 2025-04-25 11:29:35 UTC
Created attachment 181504 [details] [review]
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite

Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'
Needs to be fixed in test suite

Test plan:
Enable 'StaffLoginRestrictLibraryByIP' in prefs
Run : prove Auth.t
Should pass

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 Katrin Fischer 2025-05-06 17:46:49 UTC
Thanks for this clean-up work, Frido!
Comment 6 Katrin Fischer 2025-05-07 12:31:45 UTC
Pushed for 25.05!

Well done everyone, thank you!