Bug 39747

Summary: Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Test SuiteAssignee: Fridolin Somers <fridolin.somers>
Status: Pushed to main --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on:    
Bug Blocks: 39720    
Attachments: Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite

Description Fridolin Somers 2025-04-25 09:34:59 UTC
Correct preference is 'DefaultHoldExpirationdateUnitOfTime'.
Also no reason for ";" :

origin/main:t/db_dependent/Reserves.t:
t::lib::Mocks::mock_preference( 'DefaultHoldExpirationUnitOfTime', 'days;' );
Comment 1 Fridolin Somers 2025-04-25 09:37:00 UTC
Created attachment 181496 [details] [review]
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite

Correct preference is 'DefaultHoldExpirationdateUnitOfTime'.
Also no reason for ";".

Test by running : prove t/db_dependent/Reserves.t
Comment 2 Roman Dolny 2025-04-25 11:40:16 UTC
Created attachment 181507 [details] [review]
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite

Correct preference is 'DefaultHoldExpirationdateUnitOfTime'.
Also no reason for ";".

Test by running : prove t/db_dependent/Reserves.t

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Katrin Fischer 2025-05-07 12:31:49 UTC
Pushed for 25.05!

Well done everyone, thank you!