Summary: | Old-fashioned ILL backends (not plugins) are not working | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Pushed to main --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | major | ||
Priority: | P5 - low | CC: | martin.renvoize, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 38340 | ||
Bug Blocks: | |||
Attachments: |
Bug 39765: Revert plugin check logic
[ALTERNATE] Bug 39765: Centralize loaded plugin caching Bug 39765: Revert plugin check logic Bug 39765: Revert plugin check logic Bug 39765: Centralize loaded plugin caching |
Description
Pedro Amorim
2025-04-28 15:03:21 UTC
Thanks Pedro for testing and catching this. Created attachment 181623 [details] [review] Bug 39765: Revert plugin check logic Apply patch. Run tests. prove t/db_dependent/Koha/ILL/Requests.t Need Tomas' input here. Hmm, this is some rebase error. It should be calling get_backend_plugin instead. Created attachment 181633 [details] [review] [ALTERNATE] Bug 39765: Centralize loaded plugin caching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pedro, your patch is correct. I propose something that takes us a step further. If you consider it needs more time/thinking, we can ditch my alternate patch and work on it somewhere else. Best regards Created attachment 181634 [details] [review] Bug 39765: Revert plugin check logic Apply patch. Run tests. prove t/db_dependent/Koha/ILL/Requests.t Created attachment 181635 [details] [review] Bug 39765: Revert plugin check logic Apply patch. Run tests. prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 181638 [details] [review] Bug 39765: Centralize loaded plugin caching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> (In reply to Tomás Cohen Arazi (tcohen) from comment #6) > Pedro, your patch is correct. I propose something that takes us a step > further. If you consider it needs more time/thinking, we can ditch my > alternate patch and work on it somewhere else. > > Best regards No, that makes sense. My patch was more a proof of regression / starting point of discussion. Yours is better. Thanks Tomas and Pedro! Pushed for 25.05! Well done everyone, thank you! |