This patch: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=38340&attachment=181542 Is adding the method get_plugin but that method is never implemented. prove t/db_dependent/Koha/ILL/Requests.t t/db_dependent/Koha/ILL/Requests.t .. 6/17 # Looks like you planned 13 tests but ran 12. t/db_dependent/Koha/ILL/Requests.t .. 7/17 # Failed test 'Backend testing (mocks)' # at t/db_dependent/Koha/ILL/Requests.t line 808. The method Koha::ILL::Request->get_plugin is not covered by tests!
Thanks Pedro for testing and catching this.
Created attachment 181623 [details] [review] Bug 39765: Revert plugin check logic Apply patch. Run tests. prove t/db_dependent/Koha/ILL/Requests.t
Need Tomas' input here.
Hmm, this is some rebase error. It should be calling get_backend_plugin instead.
Created attachment 181633 [details] [review] [ALTERNATE] Bug 39765: Centralize loaded plugin caching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pedro, your patch is correct. I propose something that takes us a step further. If you consider it needs more time/thinking, we can ditch my alternate patch and work on it somewhere else. Best regards
Created attachment 181634 [details] [review] Bug 39765: Revert plugin check logic Apply patch. Run tests. prove t/db_dependent/Koha/ILL/Requests.t
Created attachment 181635 [details] [review] Bug 39765: Revert plugin check logic Apply patch. Run tests. prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 181638 [details] [review] Bug 39765: Centralize loaded plugin caching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
(In reply to Tomás Cohen Arazi (tcohen) from comment #6) > Pedro, your patch is correct. I propose something that takes us a step > further. If you consider it needs more time/thinking, we can ditch my > alternate patch and work on it somewhere else. > > Best regards No, that makes sense. My patch was more a proof of regression / starting point of discussion. Yours is better.
Thanks Tomas and Pedro!
Pushed for 25.05! Well done everyone, thank you!