Bug 39807

Summary: Problems with search bar on intranet mainpage for users with limited permissions
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 39807: Fix active tab in home-search.inc

Description Lucas Gass (lukeg) 2025-05-01 17:18:11 UTC
To recreate:

1. Make or find a staff member with staff access and list_borrowers permission. 
2. Visit the intranet mainpage and notice the 'Search catalog' label but there is no search box. 
3. Click 'Search catalog', the search bar now appears 
4. Add the 'edit_borrowers' permission
5. Revisit the intranet mainpage and notice both 'Search patrons' and 'Search catalog' links
6. Click on 'Search catalog', now you see both search bars stacked up.
Comment 1 Lucas Gass (lukeg) 2025-10-16 13:13:57 UTC
Created attachment 188007 [details] [review]
Bug 39807: Fix active tab in home-search.inc

To test:

1. Make or find a staff member with staff access and list_borrowers permission.
2. Visit the intranet mainpage and notice the 'Search catalog' label but there is no search box.
3. Click 'Search catalog', the search bar now appears
4. Add the 'edit_borrowers' permission
5. Revisit the intranet mainpage and notice both 'Search patrons' and 'Search catalog' links
6. Click on 'Search catalog', now you see both search bars stacked up.
7. APPLY PATCH
8. Try all the steps again and make sure the search bars are working properly for the limited permission user.
9. Try logging in as a superlibrarian and making sure everything still works.