To recreate: 1. Make or find a staff member with staff access and list_borrowers permission. 2. Visit the intranet mainpage and notice the 'Search catalog' label but there is no search box. 3. Click 'Search catalog', the search bar now appears 4. Add the 'edit_borrowers' permission 5. Revisit the intranet mainpage and notice both 'Search patrons' and 'Search catalog' links 6. Click on 'Search catalog', now you see both search bars stacked up.
Created attachment 188007 [details] [review] Bug 39807: Fix active tab in home-search.inc To test: 1. Make or find a staff member with staff access and list_borrowers permission. 2. Visit the intranet mainpage and notice the 'Search catalog' label but there is no search box. 3. Click 'Search catalog', the search bar now appears 4. Add the 'edit_borrowers' permission 5. Revisit the intranet mainpage and notice both 'Search patrons' and 'Search catalog' links 6. Click on 'Search catalog', now you see both search bars stacked up. 7. APPLY PATCH 8. Try all the steps again and make sure the search bars are working properly for the limited permission user. 9. Try logging in as a superlibrarian and making sure everything still works.