Summary: | Tabs need to be replaced with spaces | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, dcook, fridolin.somers, lucas, martin.renvoize, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes several files by replacing tabs with spaces and makes the QA script happy!
|
|
Version(s) released in: |
25.11.00,25.05.01
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 39324 | ||
Attachments: |
Bug 39834: Replace some tabs with spaces
Bug 39834: Replace some tabs with spaces Bug 39834: Replace some tabs with spaces |
Description
Jonathan Druart
2025-05-05 13:32:26 UTC
Created attachment 181923 [details] [review] Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Well, it's actually not really needed for the QA script. We can skip it if not considered important. Created attachment 182125 [details] [review] Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Signed-off-by: David Nind <david@davidnind.com> I've signed off, but didn't really do any testing for this. Replacing tabs with spaces makes sense to me. When using "git diff -w origin/main", it seems like there's a bit more than just replacing tabs with spaces, but overall they look minor/reasonable. The only one that is a bit weird is in t/db_dependent/Record/Record.t. I think it's replaced a tab with a \t character which is actually wrong? But it's a comment anyway, so it doesn't matter. After a quick code review, it doesn't look like any whitespace was changed in a way that would affect output. All seems pretty straightforward. I haven't tested either, but probably OK to QA, although this might be better for the next cycle... Created attachment 182162 [details] [review] Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Passing QA, but also marking with rel_25_11_candidate keyword to highlight it's for early push next cycle. Are we worried about side-effects here? I had a bit of a look and could spot any side effects.. it really just just whitespace fixing. (In reply to Martin Renvoize (ashimema) from comment #10) > I had a bit of a look and could spot any side effects.. it really just just > whitespace fixing. So should we still push? (sorry missed this for email not arriving :( ) Joubu suggested to wait for 25.11 - OK for me as this is tidy up :) Nice work everyone! Pushed to main for 25.11 I see in 25.05.x I prefer not push to 24.11.x because it does not have all tidy, there will be a lot remains tabs even with this patch No updates to the manual required. |