In order to remove false positives with the QA script we should replace some tabs with spaces.
Created attachment 181923 [details] [review] Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced
Well, it's actually not really needed for the QA script. We can skip it if not considered important.
Created attachment 182125 [details] [review] Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but didn't really do any testing for this. Replacing tabs with spaces makes sense to me.
When using "git diff -w origin/main", it seems like there's a bit more than just replacing tabs with spaces, but overall they look minor/reasonable. The only one that is a bit weird is in t/db_dependent/Record/Record.t. I think it's replaced a tab with a \t character which is actually wrong? But it's a comment anyway, so it doesn't matter.
After a quick code review, it doesn't look like any whitespace was changed in a way that would affect output. All seems pretty straightforward. I haven't tested either, but probably OK to QA, although this might be better for the next cycle...
Created attachment 182162 [details] [review] Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Passing QA, but also marking with rel_25_11_candidate keyword to highlight it's for early push next cycle.
Are we worried about side-effects here?
I had a bit of a look and could spot any side effects.. it really just just whitespace fixing.