Bug 39834 - Tabs need to be replaced with spaces
Summary: Tabs need to be replaced with spaces
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: rel_25_11_candidate
Depends on:
Blocks: 39324
  Show dependency treegraph
 
Reported: 2025-05-05 13:32 UTC by Jonathan Druart
Modified: 2025-05-16 12:19 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39834: Replace some tabs with spaces (63.71 KB, patch)
2025-05-05 13:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39834: Replace some tabs with spaces (63.68 KB, patch)
2025-05-08 21:37 UTC, David Nind
Details | Diff | Splinter Review
Bug 39834: Replace some tabs with spaces (63.82 KB, patch)
2025-05-09 10:33 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-05-05 13:32:26 UTC
In order to remove false positives with the QA script we should replace some tabs with spaces.
Comment 1 Jonathan Druart 2025-05-05 13:35:03 UTC
Created attachment 181923 [details] [review]
Bug 39834: Replace some tabs with spaces

In order to remove false positives with the QA script we should replace some tabs with spaces.

There are more but I wanted to make sure no regression would be
introduced
Comment 2 Jonathan Druart 2025-05-05 13:40:15 UTC
Well, it's actually not really needed for the QA script.
We can skip it if not considered important.
Comment 3 David Nind 2025-05-08 21:37:09 UTC
Created attachment 182125 [details] [review]
Bug 39834: Replace some tabs with spaces

In order to remove false positives with the QA script we should replace some tabs with spaces.

There are more but I wanted to make sure no regression would be
introduced

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-05-08 21:38:08 UTC
I've signed off, but didn't really do any testing for this.

Replacing tabs with spaces makes sense to me.
Comment 5 David Cook 2025-05-09 00:42:48 UTC
When using "git diff -w origin/main", it seems like there's a bit more than just replacing tabs with spaces, but overall they look minor/reasonable.

The only one that is a bit weird is in t/db_dependent/Record/Record.t. I think it's replaced a tab with a \t character which is actually wrong? But it's a comment anyway, so it doesn't matter.
Comment 6 David Cook 2025-05-09 00:48:24 UTC
After a quick code review, it doesn't look like any whitespace was changed in a way that would affect output. All seems pretty straightforward.

I haven't tested either, but probably OK to QA, although this might be better for the next cycle...
Comment 7 Martin Renvoize (ashimema) 2025-05-09 10:33:08 UTC
Created attachment 182162 [details] [review]
Bug 39834: Replace some tabs with spaces

In order to remove false positives with the QA script we should replace some tabs with spaces.

There are more but I wanted to make sure no regression would be
introduced

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 8 Martin Renvoize (ashimema) 2025-05-09 10:33:42 UTC
Passing QA, but also marking with rel_25_11_candidate keyword to highlight it's for early push next cycle.
Comment 9 Katrin Fischer 2025-05-15 05:44:36 UTC
Are we worried about side-effects here?
Comment 10 Martin Renvoize (ashimema) 2025-05-16 12:19:09 UTC
I had a bit of a look and could spot any side effects.. it really just just whitespace fixing.