Description
Jonathan Druart
2025-05-12 13:34:45 UTC
Created attachment 182305 [details] [review] Bug 39876: Move `git ls-files` to Koha::Devel::Files This patch introduces a new Koha::Devel namespace. It clearly shows that its purpose is for development and will not contain any business logic. Created attachment 182306 [details] [review] Bug 39876: Add context for tidy With this patch we adjust what's needed to make misc/devel/tidy.pl run identically as before Created attachment 182307 [details] [review] Bug 39876: Apply module to other tests We are ready to reuse Koha::Devel::Files in other places where `git ls-files` is used. Test plan: prove on the files modified by this patchset should run the same number of tests (or more) and still pass. misc/devel/tidy.pl should still work as before when using the --perl, --js and --tt options Apologies in advance for the long comment! Everything looks OK before the patches. After the patches, several tests fail: prove xt/author/codespell.t - before = 4440 PASS; after = 4616 FAIL prove xt/author/pod_checker.t - before = 3298 PASS; after = 3297 PASS prove xt/author/podcorrectness.t - before = 3297 PASS; after = 3296 PASS prove xt/find-missing-csrf.t - before = 2 PASS; after = 2 PASS prove xt/find-missing-filters.t - before = 2 PASS; after = 2 PASS prove xt/find-missing-op-in-forms.t - before = 2 PASS; after = 2 PASS prove xt/perltidy.t - before = 3018 PASS; after = 3296 FAIL prove xt/pl_valid.t - before = 3298 PASS; after = 1 FAIL prove xt/single_quotes.t - before = 2 PASS; after = 2 PASS prove xt/tt_tidy.t - before = 866 PASS; after = 3017 FAIL After the patches, and a misc/devel/tidy.pl --perl, there is a file change when you do a git status: Tidying file 1/3017 (C4/Accounts.pm) .... Tidying file 3017/3017 (xt/yaml_valid.t) kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: misc/devel/tidy.pl no changes added to commit (use "git add" and/or "git commit -a") I don't know enough about what is going on, so I haven't failed QA. Before I ran everything I had the latest koha, koha-testing-docker and images. Maybe there is something else I need to do after applying the patches? (Other than a restart_all.) Before ###### prove xt/tt_tidy.t - something went wrong error, but tests pass =============================================================== prove xt/tt_tidy.t xt/tt_tidy.t .. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. xt/tt_tidy.t .. ok All tests successful. Files=1, Tests=866, 166 wallclock secs ( 0.02 usr 0.00 sys + 1227.39 cusr 381.86 csys = 1609.27 CPU) Result: PASS misc/devel/tidy.pl --perl ========================= Tidying file 1/3016 (C4/Accounts.pm) ...... Tidying file 3016/3016 (xt/yaml_valid.t) kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 nothing to commit, working tree clean misc/devel/tidy.pl --js ======================= Tidying file 1/282 (.prettierrc.js) ..... Tidying file 282/282 (t/cypress/support/e2e.js) t/cypress/plugins/readYamlFile.js 70ms (unchanged) t/cypress/plugins/index.js 66ms (unchanged) t/cypress/plugins/mockData.js 101ms (unchanged) t/cypress/integration/t/mockData.ts 122ms (unchanged) t/cypress/support/e2e.js 202ms (unchanged) kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 nothing to commit, working tree clean misc/devel/tidy.pl --tt ======================= Tidying file 1/859 (koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc) ... Tidying file 859/859 (t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt) Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 nothing to commit, working tree clean After ##### xt/author/codespell.t - tests fail after the patches, I haven't included all the output ======================================================================================= # expected: '' xt/author/codespell.t .. 4612/4616 # Looks like you failed 72 tests of 4616. xt/author/codespell.t .. Dubious, test returned 72 (wstat 18432, 0x4800) Failed 72/4616 subtests Test Summary Report ------------------- xt/author/codespell.t (Wstat: 18432 (exited 72) Tests: 4616 Failed: 72) Failed tests: 4162, 4165-4167, 4177-4178, 4185-4186, 4191 4193-4196, 4204, 4206, 4209-4217, 4224-4225 4241, 4244-4245, 4249, 4257-4259, 4262 4264-4265, 4270-4271, 4277-4278, 4281, 4283-4288 4508, 4537-4542, 4548-4549, 4553-4554, 4556 4559-4567, 4573, 4581, 4585, 4587 Non-zero exit status: 72 Files=1, Tests=4616, 505 wallclock secs ( 1.17 usr 0.07 sys + 388.30 cusr 116.65 csys = 506.19 CPU) Result: FAIL prove xt/perltidy.t - tests fail after the patches, I haven't included all the output ====================================================================================== # Failed test at xt/perltidy.t line 14. xt/perltidy.t .. 2142/3296 # The file 'misc/devel/tidy.pl' is not tidy # +---+--------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------+ # | 36|pod2usage("--perl, --js and --tt can only be passed without any other files in parameter") |pod2usage("--perl, --js and --tt can only be passed without any other files in parameter") | # | 37| if @files && ( $perl_files || $js_files || $tt_files ); | if @files && ( $perl_files || $js_files || $tt_files ); | # | 38| | | # * 39|my $dev_files = Koha::Devel::Files->new({context => 'tidy'}); |my $dev_files = Koha::Devel::Files->new( { context => 'tidy' } ); * # | 40| | | # | 41|my @original_files = @files; |my @original_files = @files; | # | 42|if (@files) { |if (@files) { | # +---+--------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------+ # Failed test at xt/perltidy.t line 14. xt/perltidy.t .. 3266/3296 # Looks like you failed 280 tests of 3296. xt/perltidy.t .. Dubious, test returned 254 (wstat 65024, 0xfe00) Failed 280/3296 subtests Test Summary Report ------------------- xt/perltidy.t (Wstat: 65024 (exited 254) Tests: 3296 Failed: 280) Failed tests: 794, 796-1073, 2163 Non-zero exit status: 254 Files=1, Tests=3296, 174 wallclock secs ( 0.79 usr 0.09 sys + 173.36 cusr 0.52 csys = 174.76 CPU) Result: FAIL prove xt/pl_valid.t - tests fail after the patches, I haven't included all the output ===================================================================================== prove xt/pl_valid.t xt/pl_valid.t .. Global symbol "@exceptions" requires explicit package name (did you forget to declare "my @exceptions"?) at xt/pl_valid.t line 44. Execution of xt/pl_valid.t aborted due to compilation errors. xt/pl_valid.t .. 1/? # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 1. xt/pl_valid.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 1 subtests passed Test Summary Report ------------------- xt/pl_valid.t (Wstat: 65280 (exited 255) Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: No plan found in TAP output Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.07 cusr 0.02 csys = 0.10 CPU) Result: FAIL prove xt/tt_tidy.t - tests fail after the patches, I haven't included all the output ==================================================================================== prove xt/tt_tidy.t xt/tt_tidy.t .. 1/? # Failed test 'misc/devel/tidy.pl should be kept tidy' # at xt/tt_tidy.t line 47. # Looks like you failed 1 test of 3017. xt/tt_tidy.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3017 subtests Test Summary Report ------------------- xt/tt_tidy.t (Wstat: 256 (exited 1) Tests: 3017 Failed: 1) Failed test: 1884 Non-zero exit status: 1 Files=1, Tests=3017, 382 wallclock secs ( 0.06 usr 0.01 sys + 1396.55 cusr 288.22 csys = 1684.84 CPU) Result: FAIL misc/devel/tidy.pl --perl Tidying file 1/3017 (C4/Accounts.pm) ...... Tidying file 3017/3017 (xt/yaml_valid.t) kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: misc/devel/tidy.pl no changes added to commit (use "git add" and/or "git commit -a") misc/devel/tidy.pl --perl ========================= Tidying file 1/3017 (C4/Accounts.pm) .... Tidying file 3017/3017 (xt/yaml_valid.t) kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: misc/devel/tidy.pl no changes added to commit (use "git add" and/or "git commit -a") misc/devel/tidy.pl --js ======================= Tidying file 1/282 (.prettierrc.js) ..... t/cypress/integration/Preservation/Trains.ts 255ms (unchanged) kohadev-koha@kohadevbox:koha(bz39876)$ git status On branch bz39876 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: misc/devel/tidy.pl no changes added to commit (use "git add" and/or "git commit -a") misc/devel/tidy.pl --tt ======================= Tidying file 1/859 (koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc) Created attachment 182344 [details] [review] Bug 39876: Move `git ls-files` to Koha::Devel::Files This patch introduces a new Koha::Devel namespace. It clearly shows that its purpose is for development and will not contain any business logic. Created attachment 182345 [details] [review] Bug 39876: Add context for tidy With this patch we adjust what's needed to make misc/devel/tidy.pl run identically as before Created attachment 182346 [details] [review] Bug 39876: Apply module to other tests We are ready to reuse Koha::Devel::Files in other places where `git ls-files` is used. (In reply to David Nind from comment #5) > Apologies in advance for the long comment! > > Everything looks OK before the patches. > > After the patches, several tests fail: > > prove xt/author/codespell.t - before = 4440 PASS; after = 4616 FAIL It was missing the exclusion list. after 4439 > prove xt/perltidy.t - before = 3018 PASS; after = 3296 FAIL It was missing the exclusion list. > prove xt/pl_valid.t - before = 3298 PASS; after = 1 FAIL Fixed now. In the test plan I stated that there should be more files tested after than before. It's actually true, but the number of tests does not exactly represent the number of files tested, because of duplication. Here is the diff of the list of files: 350a351 > Koha/Devel/Files.pm 2341d2341 < opac/svc/shelfbrowser.pl 2440d2439 < svc/cataloguing/automatic_linker.pl Those 2 svc files are actually duplicated in the "main" version and are tested twice. > prove xt/tt_tidy.t - before = 866 PASS; after = 3017 FAIL Oops, it was retrieving the perl files :-/ It's fixed now. There is this difference in the files tested: 86d85 < koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc 714d712 < koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc 854,858d851 < misc/cronjobs/rss/lastAcquired-1.0.tt < misc/cronjobs/rss/lastAcquired-2.0.tt < misc/cronjobs/rss/lastAcquired.tt < misc/cronjobs/rss/longestUnseen.tt < misc/cronjobs/rss/mostReserved.tt This is because we are fixing an inconsistency: misc/devel/tidy.pl was excluding them, but xt/tt_tidy.t was not (but the files was skipped later anyway). Now they are excluded for both. > After the patches, and a misc/devel/tidy.pl --perl, there is a file change > when you do a git status: Oops, fixed now. > Maybe there is something else I need to do after applying the patches? > (Other than a restart_all.) Nope, it's just me submitting patches too late in the evening, and being lazy to run again the whole test suite. Sorry about that and thanks a lot for your testing! Created attachment 182354 [details] [review] Bug 39876: Apply module to other tests We are ready to reuse Koha::Devel::Files in other places where `git ls-files` is used. Created attachment 182380 [details] [review] Bug 39876: Move `git ls-files` to Koha::Devel::Files This patch introduces a new Koha::Devel namespace. It clearly shows that its purpose is for development and will not contain any business logic. Signed-off-by: David Nind <david@davidnind.com> Created attachment 182381 [details] [review] Bug 39876: Add context for tidy With this patch we adjust what's needed to make misc/devel/tidy.pl run identically as before Signed-off-by: David Nind <david@davidnind.com> Created attachment 182382 [details] [review] Bug 39876: Apply module to other tests We are ready to reuse Koha::Devel::Files in other places where `git ls-files` is used. Signed-off-by: David Nind <david@davidnind.com> Thanks Jonathan! Tests now all pass and tidying files works as expected (no changes identified). Testing notes (using KTD, on main): 1. Run these tests, they should all pass: - prove xt/author/codespell.t - before = 4440 PASS; after = 4439 PASS - prove xt/author/pod_checker.t - before = 3298 PASS; after = 3297 PASS - prove xt/author/podcorrectness.t - before = 3297 PASS; after = 3296 PASS - prove xt/find-missing-csrf.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-filters.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-op-in-forms.t - before = 2 PASS; after = 2 PASS - prove xt/perltidy.t - before = 3018 PASS; after = 3017 PASS - prove xt/pl_valid.t - before = 3298 PASS; after = 3293 PASS - prove xt/single_quotes.t - before = 2 PASS; after = 2 PASS - prove xt/tt_tidy.t - before = 866 PASS; after = 3017 PASS 2. Tidy all the files, there should be no changes using a git status: - misc/devel/tidy.pl --perl - misc/devel/tidy.pl --js - misc/devel/tidy.pl --tt > prove xt/tt_tidy.t - before = 866 PASS; after = 3017 PASS
Are you sure about this "after" number?
I cannot test right now, but it does not look correct.
(In reply to Jonathan Druart from comment #15) > > prove xt/tt_tidy.t - before = 866 PASS; after = 3017 PASS > > Are you sure about this "after" number? > I cannot test right now, but it does not look correct. I thought I'd updated it, but looks like I didn't? After the patches it is now 3019. I re-ran, and this is the result now after the patches are applied: prove xt/tt_tidy.t xt/tt_tidy.t .. ok All tests successful. Files=1, Tests=3019, 382 wallclock secs ( 0.06 usr 0.00 sys + 1188.61 cusr 261.40 csys = 1450.07 CPU) Result: PASS Created attachment 182417 [details] [review] Bug 39876: Get TT files for tt_tidy Well then it's wrong. I am sure I fixed that before! It is now with the last patch. (In reply to Jonathan Druart from comment #18) > Well then it's wrong. I am sure I fixed that before! > It is now with the last patch. Now 859 after the additional patch. I re-ran everything on the latest main: 1. Run these tests, they should all pass: - prove xt/author/codespell.t - before = 4442 PASS; after = 4441 PASS - prove xt/author/pod_checker.t - before = 3300 PASS; after = 3299 PASS - prove xt/author/podcorrectness.t - before = 3299 PASS; after = 3298 PASS - prove xt/find-missing-csrf.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-filters.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-op-in-forms.t - before = 2 PASS; after = 2 PASS - prove xt/perltidy.t - before = 3020 PASS; after = 3019 PASS - prove xt/pl_valid.t - before = 3300 PASS; after = 3295 PASS - prove xt/single_quotes.t - before = 2 PASS; after = 2 PASS - prove xt/tt_tidy.t - before = 866 PASS; after = 859 PASS [1] 2. Tidy all the files, there should be no changes using a git status: - misc/devel/tidy.pl --perl (before = 3018 files, no changes; after = 3019 files) - misc/devel/tidy.pl --js (before = 282 files, no changes; after = 282 files) - misc/devel/tidy.pl --tt (before = 859 files, no changes; after = 859 files) [2] [3] [1] prove xt/tt_tidy.t - after patch ------------------------------------- prove xt/tt_tidy.t xt/tt_tidy.t .. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. xt/tt_tidy.t .. ok All tests successful. Files=1, Tests=859, 167 wallclock secs ( 0.03 usr 0.01 sys + 1237.54 cusr 390.78 csys = 1628.36 CPU) Result: PASS [2] misc/devel/tidy.pl --tt - before patches -------------------------------------------- Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept [3] misc/devel/tidy.pl --tt - after patches ------------------------------------------- Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept Created attachment 182461 [details] [review] Bug 39876: Get TT files for tt_tidy Signed-off-by: David Nind <david@davidnind.com> (In reply to Jonathan Druart from comment #18) > Well then it's wrong. I am sure I fixed that before! > It is now with the last patch. Re-replying as I didn't include a before patch results for for prove xt/tt_tidy.t. Now 859 after the additional patch. I re-ran everything on the latest main: 1. Run these tests, they should all pass: - prove xt/author/codespell.t - before = 4442 PASS; after = 4441 PASS - prove xt/author/pod_checker.t - before = 3300 PASS; after = 3299 PASS - prove xt/author/podcorrectness.t - before = 3299 PASS; after = 3298 PASS - prove xt/find-missing-csrf.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-filters.t - before = 2 PASS; after = 2 PASS - prove xt/find-missing-op-in-forms.t - before = 2 PASS; after = 2 PASS - prove xt/perltidy.t - before = 3020 PASS; after = 3019 PASS - prove xt/pl_valid.t - before = 3300 PASS; after = 3295 PASS - prove xt/single_quotes.t - before = 2 PASS; after = 2 PASS - prove xt/tt_tidy.t - before = 866 PASS; after = 859 PASS [1] [2] 2. Tidy all the files, there should be no changes using a git status: - misc/devel/tidy.pl --perl (before = 3018 files, no changes; after = 3019 files) - misc/devel/tidy.pl --js (before = 282 files, no changes; after = 282 files) - misc/devel/tidy.pl --tt (before = 859 files, no changes; after = 859 files) [3] [4] [1] prove xt/tt_tidy.t - before patch ------------------------------------- prove xt/tt_tidy.t xt/tt_tidy.t .. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. xt/tt_tidy.t .. ok All tests successful. Files=1, Tests=866, 168 wallclock secs ( 0.02 usr 0.00 sys + 1242.16 cusr 390.99 csys = 1633.17 CPU) Result: PASS [2] prove xt/tt_tidy.t - after patch ------------------------------------- prove xt/tt_tidy.t xt/tt_tidy.t .. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 108. xt/tt_tidy.t .. ok All tests successful. Files=1, Tests=859, 168 wallclock secs ( 0.03 usr 0.01 sys + 1230.65 cusr 387.11 csys = 1617.80 CPU) Result: PASS [3] misc/devel/tidy.pl --tt - before patches -------------------------------------------- Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept [4] misc/devel/tidy.pl --tt - after patches ------------------------------------------- Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept * koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Something went wrong, Prettier generated an empty file. The original file was kept Thanks a lot, David! Created attachment 183618 [details] [review] Bug 39876: Move `git ls-files` to Koha::Devel::Files This patch introduces a new Koha::Devel namespace. It clearly shows that its purpose is for development and will not contain any business logic. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 183619 [details] [review] Bug 39876: Add context for tidy With this patch we adjust what's needed to make misc/devel/tidy.pl run identically as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 183620 [details] [review] Bug 39876: Apply module to other tests We are ready to reuse Koha::Devel::Files in other places where `git ls-files` is used. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 183621 [details] [review] Bug 39876: Get TT files for tt_tidy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 183622 [details] [review] Bug 39876: Add build-git-snapshot type resolution Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 183623 [details] [review] Bug 39876: Make find-missing-op-in-forms.t test TT files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 183625 [details] [review] Bug 39876: Add build-git-snapshot type resolution Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Ok, only a minor tweak and porting the change from bug 40261 here. I made it dependent on it because otherwise `xt/perltidy.t` would fail. They should be pushed together. |