Bug 40261 - Tidy `build-git-snapshot`
Summary: Tidy `build-git-snapshot`
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 38664 40039
Blocks: 39876
  Show dependency treegraph
 
Reported: 2025-06-27 13:58 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-07-28 08:46 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 40261: Teach tidy.pl how to handle build-git-snapshot (1.25 KB, patch)
2025-06-27 14:10 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40261: Teach tidy.pl how to handle build-git-snapshot (1.25 KB, patch)
2025-06-27 14:13 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40261: Tidy debian/build-git-snapshot (5.67 KB, patch)
2025-06-27 14:13 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40261: Tidy debian/build-git-snapshot (5.71 KB, patch)
2025-06-27 14:33 UTC, David Flater
Details | Diff | Splinter Review
Bug 40261: Teach tidy.pl how to handle build-git-snapshot (1.25 KB, patch)
2025-06-27 14:47 UTC, David Flater
Details | Diff | Splinter Review
Bug 40261: Tidy debian/build-git-snapshot (5.71 KB, patch)
2025-06-27 14:47 UTC, David Flater
Details | Diff | Splinter Review
Bug 40261: Tidy debian/build-git-snapshot (5.78 KB, patch)
2025-07-03 15:30 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-06-27 13:58:14 UTC
It needs to be considered a Perl script.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-06-27 14:10:05 UTC
Created attachment 183608 [details] [review]
Bug 40261: Teach tidy.pl how to handle build-git-snapshot

This patch makes the `tidy.pl` script handle the mentioned script as a Perl script.

To test:
1. Run:
   $ ktd --shell
  k$ perl misc/devel/tidy.pl debian/build-git-snapshot
=> FAIL: You get:

```
Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234.
```

2. Apply this patch
3. Repeat 1
=> SUCCESS: It tidies the file!
4. Reset to the current head
  k$ git reset --hard HEAD
5. Apply the tidy patch
6. Repeat 1
7. Run:
  k$ git diff
=> SUCCESS: No diff, the file is tidy
8. Sign off :-D
Comment 2 Tomás Cohen Arazi (tcohen) 2025-06-27 14:13:52 UTC
Created attachment 183610 [details] [review]
Bug 40261: Teach tidy.pl how to handle build-git-snapshot

This patch makes the `tidy.pl` script handle the mentioned script as a Perl script.

To test:
1. Run:
   $ ktd --shell
  k$ perl misc/devel/tidy.pl debian/build-git-snapshot
=> FAIL: You get:

```
Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234.
```

2. Apply this patch
3. Repeat 1
=> SUCCESS: It tidies the file!
4. Reset to the current head
  k$ git reset --hard HEAD
5. Apply the tidy patch
6. Repeat 1
7. Run:
  k$ git diff
=> SUCCESS: No diff, the file is tidy
8. Sign off :-D
Comment 3 Tomás Cohen Arazi (tcohen) 2025-06-27 14:13:55 UTC
Created attachment 183611 [details] [review]
Bug 40261: Tidy debian/build-git-snapshot
Comment 4 David Flater 2025-06-27 14:33:01 UTC
Created attachment 183612 [details] [review]
Bug 40261: Tidy debian/build-git-snapshot

Signed-off-by: David Flater <flaterdavid@gmail.com>
Comment 5 David Flater 2025-06-27 14:47:51 UTC
Created attachment 183613 [details] [review]
Bug 40261: Teach tidy.pl how to handle build-git-snapshot

This patch makes the `tidy.pl` script handle the mentioned script as a Perl script.

To test:
1. Run:
   $ ktd --shell
  k$ perl misc/devel/tidy.pl debian/build-git-snapshot
=> FAIL: You get:

```
Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234.
```

2. Apply this patch
3. Repeat 1
=> SUCCESS: It tidies the file!
4. Reset to the current head
  k$ git reset --hard HEAD
5. Apply the tidy patch
6. Repeat 1
7. Run:
  k$ git diff
=> SUCCESS: No diff, the file is tidy
8. Sign off :-D
Comment 6 David Flater 2025-06-27 14:47:53 UTC
Created attachment 183614 [details] [review]
Bug 40261: Tidy debian/build-git-snapshot

Signed-off-by: David Flater <flaterdavid@gmail.com>
Comment 7 Jonathan Druart 2025-06-27 15:20:29 UTC
Will conflict with bug 39876...
Comment 8 Tomás Cohen Arazi (tcohen) 2025-06-27 17:45:21 UTC
(In reply to Jonathan Druart from comment #7)
> Will conflict with bug 39876...

Moved my change to that bug. And PQA it :-D
Comment 9 Tomás Cohen Arazi (tcohen) 2025-06-27 17:56:25 UTC
I moved the logic change into 39876. Keeping the tidy here.
Comment 10 Martin Renvoize (ashimema) 2025-07-03 15:30:37 UTC
Created attachment 183768 [details] [review]
Bug 40261: Tidy debian/build-git-snapshot

Signed-off-by: David Flater <flaterdavid@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 11 Martin Renvoize (ashimema) 2025-07-03 15:30:51 UTC
Simply tidy.. Passing QA
Comment 12 Lucas Gass (lukeg) 2025-07-07 16:23:36 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 13 Paul Derscheid 2025-07-10 20:51:07 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 14 Fridolin Somers 2025-07-28 08:46:49 UTC
Pushed to 24.11.x for 24.11.08