Summary: | NEW_SUGGESTION email notices end up in the patrons notice tab (members/notices.pl) when they should not | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Notices | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Pushed to main --- | QA Contact: | Pedro Amorim <pedro.amorim> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | george, michael.adamyk, pedro.amorim |
Version: | Main | Keywords: | additional_work_needed |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
The patch makes it so NEW_SUGGESTION email notices do not show up in a patron's notice history.
|
|
Version(s) released in: |
25.11.00
|
Circulation function: | |
Attachments: |
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices Bug 39883: ( follow-up ) Adjust tests to not rely on borrowernumber Bug 39883: (follow-up) Retrieve messages by letter_code |
Description
Lucas Gass (lukeg)
2025-05-12 20:53:50 UTC
Created attachment 182315 [details] [review] Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. Created attachment 182391 [details] [review] Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com> Created attachment 185133 [details] [review] Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Created attachment 185467 [details] [review] Bug 39883: ( follow-up ) Adjust tests to not rely on borrowernumber Actually, a better way to get the data I want is to replace the search by borrowernumber with letter_code => 'NEW_SUGGESTION Created attachment 185471 [details] [review] Bug 39883: (follow-up) Retrieve messages by letter_code follow-up pushed to main |