Bug 39883

Summary: NEW_SUGGESTION email notices end up in the patrons notice tab (members/notices.pl) when they should not
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: NoticesAssignee: Lucas Gass (lukeg) <lucas>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: george, michael.adamyk
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices

Description Lucas Gass (lukeg) 2025-05-12 20:53:50 UTC
To recreate:

1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions.
2. Create a new suggestion and set the "
Created by:" field to a patron with an email address
3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" )
4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions.
5. The borrowernumber is the borrower who made the suggestion.

This shouldn't end up in the notice tab for the borrower since these notices are for staff.
Comment 1 Lucas Gass (lukeg) 2025-05-12 21:56:21 UTC
Created attachment 182315 [details] [review]
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices

1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions.
2. Create a new suggestion and set the "
Created by:" field to a patron with an email address
3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" )
4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions.
5. The borrowernumber is the borrower who made the suggestion.
6. APPLY PATCH, restart_all
7. Repeat steps 2 - 4.
8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef
9. Check in the patron's notice tab, there should be nothing queued.
Comment 2 Lin Wei 2025-05-13 16:22:48 UTC
Created attachment 182391 [details] [review]
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices

1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions.
2. Create a new suggestion and set the "
Created by:" field to a patron with an email address
3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" )
4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions.
5. The borrowernumber is the borrower who made the suggestion.
6. APPLY PATCH, restart_all
7. Repeat steps 2 - 4.
8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef
9. Check in the patron's notice tab, there should be nothing queued.

Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com>