Summary: | Fatal errors from SIP server are not logged | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | dcook, kyle, tristin.stagg |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 39911: Introduce failure in patron information request [DO NOT PUSH]
Bug 39911: Trap DIE signals in SIP server Bug 39911: Trap DIE signals in SIP server Bug 39911: Trap DIE signals in SIP server |
Description
Kyle M Hall (khall)
2025-05-15 17:23:10 UTC
Created attachment 182501 [details] [review] Bug 39911: Introduce failure in patron information request [DO NOT PUSH] Created attachment 182502 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Created attachment 182503 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Created attachment 182508 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger <magnus@libriotech.no> |