Summary: | Fatal errors from SIP server are not logged | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | Pushed to oldstable --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, dcook, fridolin.somers, kyle, lucas, tomascohen, tristin.stagg |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40144 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This restores the logging of fatal SIP errors to both the SIP logs and standard output from the command line.
|
|
Version(s) released in: |
25.11.00,25.05.01,24.11.08
|
Circulation function: | |
Attachments: |
Bug 39911: Introduce failure in patron information request [DO NOT PUSH]
Bug 39911: Trap DIE signals in SIP server Bug 39911: Trap DIE signals in SIP server Bug 39911: Trap DIE signals in SIP server Bug 39911: Trap DIE signals in SIP server Bug 39911: Add POD Bug 39911: (RM follow-up) Use logger warn Bug 39911: Remove redundant warn |
Description
Kyle M Hall (khall)
2025-05-15 17:23:10 UTC
Created attachment 182501 [details] [review] Bug 39911: Introduce failure in patron information request [DO NOT PUSH] Created attachment 182502 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Created attachment 182503 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Created attachment 182508 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 183078 [details] [review] Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work everyone! Pushed to main for 25.11 This is causing tests to fail in main due to bad POD coverage. xt/author/pod_coverage.t is failing Created attachment 183203 [details] [review] Bug 39911: Add POD I think its actually the bare 'warn' that is causing test to fail. I think we should use $logger->warn() Created attachment 183212 [details] [review] Bug 39911: (RM follow-up) Use logger warn Tests are still failing here, even with Kyle's follow-up. Created attachment 183247 [details] [review] Bug 39911: Remove redundant warn Following the original test plan you notice, `THIS IS A TEST` is printed twice: * In the logs. * In STDERR for the SIP server. The latter is redundant, and also problematic for `xt/author/pod_coverage.t` which fails the `no warnings` tests because of that. To test: 1. Run: $ ktd --shell k$ prove xt/author/pod_coverage.t => FAIL: Scary errors, lots of them 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Follow the original bug test plan => SUCCESS: There's `THIS IS A TEST` in the logs, which was the author's goal in the first place. 5. Sign off :-D 6. Visit bug 40144 :-P Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Lucas Gass (lukeg) from comment #11) > Tests are still failing here, even with Kyle's follow-up. Lucas, I checked the warn is not required to accomplish Kyle's goal so it is ok to push my follow-up. Cheers. Follow-ups pushed to main, thank you! Nice work everyone! Pushed to 25.05.x for 25.05.03 Pushed to 24.11.x for 24.11.08 |