Whiel debugging tests for 39911 I noticed a couple warnings that are useless (i.e. poor data handling instead of a feature alerting something). The first patch on bug 39911 adds an explicit `die` to emulate a a crash. When running the `sip_cliemulator.pl` script some warnings showed up: ```shell $ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su tcohen -sp tomasito -l MPL --patron tcohen -m patron_information Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 127. SEND: 9300CNtcohen|COtomasito|CPMPL| Use of uninitialized value $data in concatenation (.) or string at ./misc/sip_cli_emulator.pl line 359. READ: Use of uninitialized value $data in pattern match (m//) at ./misc/sip_cli_emulator.pl line 311. Login Failed! ```
Created attachment 183248 [details] [review] Bug 40144: Get rid of `sip_cli_emulator.pl` warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 183253 [details] [review] Bug 40144: Get rid of `sip_cli_emulator.pl` warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Run ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su tcohen -sp tomasito -l MPL --patron tcohen -m patron_information 2. Notice the "Use of unitialized value in...." in the output: Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/ sip_cli_emulator.pl line 127. SEND: 9300CNtcohen|COtomasito|CPMPL| READ: 940 Login Failed! 3. Apply the patch. 4. Repeat step 1. 5. Notice that there is now no "Use of unitialized value in...." in the output: Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNtcohen|COtomasito|CPMPL| READ: 940 Login Failed!
Created attachment 183462 [details] [review] Bug 40144: Get rid of `sip_cli_emulator.pl` warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x for 25.05.01
Pushed to 24.11.x for 24.11.08
Not backporting to 22.11.x as it wasn't backported to 24.05.x