Summary: | Cancel selected holds button on the holds awaiting pickup page is the same color as the background | ||
---|---|---|---|
Product: | Koha | Reporter: | Benjamin Daeuber <bdaeuber> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | minor | ||
Priority: | P5 - low | CC: | clackman, david, emily.lamancusa, gmcharlt, mteal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the cancel selected holds buttons on the holds awaiting pickup page (under the tabs) (Circulation > Holds > Holds awaiting pickup). The light grey background was removed, and you can now see the cancel selected holds buttons.
It also links the TransferWhenCancelAllWaitingHolds system preference under the "Holds waiting past their expiration date", if the staff patron has permission to change system preferences.
|
|
Version(s) released in: |
25.11.00
|
Circulation function: | |
Attachments: |
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background Bug 39939: (follow-up) Fix terminology - syspref to system preference Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background Bug 39939: (follow-up) Fix terminology - syspref to system preference |
Description
Benjamin Daeuber
2025-05-19 21:22:18 UTC
Created attachment 182929 [details] [review] Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries Created attachment 182956 [details] [review] Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries Created attachment 182961 [details] [review] Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 182962 [details] [review] Bug 39939: (follow-up) Fix terminology - syspref to system preference Spell system preference in full, instead of syspref. Signed-off-by: David Nind <david@davidnind.com> It'd be great if the color of the button fix could get ported back to 24.11 It's confusing to staff to not have any indication of the button until you hover over the "Cancel selected" words. Created attachment 183495 [details] [review] Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 183496 [details] [review] Bug 39939: (follow-up) Fix terminology - syspref to system preference Spell system preference in full, instead of syspref. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Nice work everyone! Pushed to main for 25.11 |