Bug 39939 - Cancel selected holds button on the holds awaiting pickup page is the same color as the background
Summary: Cancel selected holds button on the holds awaiting pickup page is the same co...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-19 21:22 UTC by Benjamin Daeuber
Modified: 2025-06-26 17:11 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the cancel selected holds buttons on the holds awaiting pickup page (under the tabs) (Circulation > Holds > Holds awaiting pickup). The light grey background was removed, and you can now see the cancel selected holds buttons. It also links the TransferWhenCancelAllWaitingHolds system preference under the "Holds waiting past their expiration date", if the staff patron has permission to change system preferences.
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background (5.76 KB, patch)
2025-06-03 18:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background (6.63 KB, patch)
2025-06-04 16:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background (6.67 KB, patch)
2025-06-04 23:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 39939: (follow-up) Fix terminology - syspref to system preference (1.71 KB, patch)
2025-06-04 23:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background (6.74 KB, patch)
2025-06-25 13:16 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 39939: (follow-up) Fix terminology - syspref to system preference (1.78 KB, patch)
2025-06-25 13:16 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Daeuber 2025-05-19 21:22:18 UTC
It's hard to tell "Cancel Selected" on the Holds Awaiting Pickup screen is a button at all. It should have a different color than the background.
Comment 1 Owen Leonard 2025-06-03 18:59:05 UTC
Created attachment 182929 [details] [review]
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background

This patch makes some minor changes to the "Holds awaiting pickup" page
so that the cancel buttons are clear and usable.

The patch also wraps the reference to the
TransferWhenCancelAllWaitingHolds system preference in a permission
check so that it can be linked to the preference when appropriate.

To test you should have some waiting holds in three categories:

1. Holds which have not been waiting longer than the number of days
   specified in the ReservesMaxPickUpDelay system preference.

2. Holds which have been waiting longer. I belive the only way to test
   this is to manually update the expiration date of an already waiting
   hold so that it is in the past.

3. Waiting holds which a patron has requested be cancelled. (Requires
   that the patron and hold are allowed according to the "Cancellation
   allowed" setting under Administration -> Circulation and fine rules
   -> Default waiting hold cancellation policy.
   - Log in to the OPAC as a patron who has a waiting hold. On the "Your
   summary" page, under the "Holds" tab, click the "Request to cancel"
   button for at least one of the waiting holds.

- In the staff interface, go to Circulation -> Holds awaiting pickup.
  - Under each tab, check the appearance of the "Cancel selected"
    buttons (and the "Cancel and transfer all" button under "Holds
    awaiting past..." tab).
- When testing as a user with system preference privileges, and the
  TransferWhenCancelAllWaitingHolds preference set to "Don't transfer,"
  the hint shown under the "Holds awaiting past..." tab should be linked
  to system preferences. A user without system preference privileges
  should not see a link.

Sponsored-by: Athens County Public Libraries
Comment 2 Owen Leonard 2025-06-04 16:06:34 UTC
Created attachment 182956 [details] [review]
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background

This patch makes some minor changes to the "Holds awaiting pickup" page
so that the cancel buttons are clear and usable.

The patch also wraps the reference to the
TransferWhenCancelAllWaitingHolds system preference in a permission
check so that it can be linked to the preference when appropriate.

To test you should have some waiting holds in three categories:

1. Holds which have not been waiting longer than the number of days
   specified in the ReservesMaxPickUpDelay system preference.

2. Holds which have been waiting longer. I belive the only way to test
   this is to manually update the expiration date of an already waiting
   hold so that it is in the past.

3. Waiting holds which a patron has requested be cancelled. (Requires
   that the patron and hold are allowed according to the "Cancellation
   allowed" setting under Administration -> Circulation and fine rules
   -> Default waiting hold cancellation policy.
   - Log in to the OPAC as a patron who has a waiting hold. On the "Your
   summary" page, under the "Holds" tab, click the "Request to cancel"
   button for at least one of the waiting holds.

- In the staff interface, go to Circulation -> Holds awaiting pickup.
  - Under each tab, check the appearance of the "Cancel selected"
    buttons (and the "Cancel and transfer all" button under "Holds
    awaiting past..." tab).
- When testing as a user with system preference privileges, and the
  TransferWhenCancelAllWaitingHolds preference set to "Don't transfer,"
  the hint shown under the "Holds awaiting past..." tab should be linked
  to system preferences. A user without system preference privileges
  should not see a link.

Sponsored-by: Athens County Public Libraries
Comment 3 David Nind 2025-06-04 23:54:33 UTC
Created attachment 182961 [details] [review]
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background

This patch makes some minor changes to the "Holds awaiting pickup" page
so that the cancel buttons are clear and usable.

The patch also wraps the reference to the
TransferWhenCancelAllWaitingHolds system preference in a permission
check so that it can be linked to the preference when appropriate.

To test you should have some waiting holds in three categories:

1. Holds which have not been waiting longer than the number of days
   specified in the ReservesMaxPickUpDelay system preference.

2. Holds which have been waiting longer. I belive the only way to test
   this is to manually update the expiration date of an already waiting
   hold so that it is in the past.

3. Waiting holds which a patron has requested be cancelled. (Requires
   that the patron and hold are allowed according to the "Cancellation
   allowed" setting under Administration -> Circulation and fine rules
   -> Default waiting hold cancellation policy.
   - Log in to the OPAC as a patron who has a waiting hold. On the "Your
   summary" page, under the "Holds" tab, click the "Request to cancel"
   button for at least one of the waiting holds.

- In the staff interface, go to Circulation -> Holds awaiting pickup.
  - Under each tab, check the appearance of the "Cancel selected"
    buttons (and the "Cancel and transfer all" button under "Holds
    awaiting past..." tab).
- When testing as a user with system preference privileges, and the
  TransferWhenCancelAllWaitingHolds preference set to "Don't transfer,"
  the hint shown under the "Holds awaiting past..." tab should be linked
  to system preferences. A user without system preference privileges
  should not see a link.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-06-04 23:54:37 UTC
Created attachment 182962 [details] [review]
Bug 39939: (follow-up) Fix terminology - syspref to system preference

Spell system preference in full, instead of syspref.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 mteal 2025-06-17 19:12:24 UTC
It'd be great if the color of the button fix could get ported back to 24.11 It's confusing to staff to not have any indication of the button until you hover over the "Cancel selected" words.
Comment 6 Emily Lamancusa (emlam) 2025-06-25 13:16:28 UTC
Created attachment 183495 [details] [review]
Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background

This patch makes some minor changes to the "Holds awaiting pickup" page
so that the cancel buttons are clear and usable.

The patch also wraps the reference to the
TransferWhenCancelAllWaitingHolds system preference in a permission
check so that it can be linked to the preference when appropriate.

To test you should have some waiting holds in three categories:

1. Holds which have not been waiting longer than the number of days
   specified in the ReservesMaxPickUpDelay system preference.

2. Holds which have been waiting longer. I belive the only way to test
   this is to manually update the expiration date of an already waiting
   hold so that it is in the past.

3. Waiting holds which a patron has requested be cancelled. (Requires
   that the patron and hold are allowed according to the "Cancellation
   allowed" setting under Administration -> Circulation and fine rules
   -> Default waiting hold cancellation policy.
   - Log in to the OPAC as a patron who has a waiting hold. On the "Your
   summary" page, under the "Holds" tab, click the "Request to cancel"
   button for at least one of the waiting holds.

- In the staff interface, go to Circulation -> Holds awaiting pickup.
  - Under each tab, check the appearance of the "Cancel selected"
    buttons (and the "Cancel and transfer all" button under "Holds
    awaiting past..." tab).
- When testing as a user with system preference privileges, and the
  TransferWhenCancelAllWaitingHolds preference set to "Don't transfer,"
  the hint shown under the "Holds awaiting past..." tab should be linked
  to system preferences. A user without system preference privileges
  should not see a link.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa (emlam) 2025-06-25 13:16:31 UTC
Created attachment 183496 [details] [review]
Bug 39939: (follow-up) Fix terminology - syspref to system preference

Spell system preference in full, instead of syspref.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 8 Lucas Gass (lukeg) 2025-06-26 17:11:51 UTC
Nice work everyone!

Pushed to main for 25.11