Bug 39948

Summary: Simplify unauthenticated ILL request detail in the OPAC
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: TemplatesAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Passed QA --- QA Contact: Pedro Amorim <pedro.amorim>
Severity: enhancement    
Priority: P5 - low CC: david, katrin.fischer, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
This enhancement simplifies the unauthenticated ILL submission detail page for the OPAC. It removes 'Unauthenticated ...' in front og the labels for the first name, last name, and email fields.
Version(s) released in:
Circulation function:
Bug Depends on: 36197    
Bug Blocks:    
Attachments: Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

Description Tomás Cohen Arazi (tcohen) 2025-05-20 18:18:47 UTC
There are labels like:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

'Unauthenticated' feels like an internal thing for staff, and something really weird for an end user to read. It already displays in the 'Status' row.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-05-20 18:25:31 UTC
Created attachment 182681 [details] [review]
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

This patch tweaks the unauthenticated ILL request details page so it
doesn't display 'Unauthenticated ...' more than really needed.

To test:
1. Enable ILLModule
2. Enable ILLOpacUnauthenticatedRequest
3. Set ILLOpacbackends to 'Standard'
4. Make a search in the OPAC (not logged in)
5. At the bottom of the page, follow the 'Make an interlibrary loan
   request' link.
6. Place a request, you are redirected to the request details page
=> FAIL: There are some strings that could go away:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

7. Apply this patch
8. Reload the page
=> SUCCESS: It looks more polished, with no 'Unauthenticated' all over
the place. You still see 'Status: Unauthenticated' anyway
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2025-05-21 08:13:22 UTC
Created attachment 182685 [details] [review]
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

This patch tweaks the unauthenticated ILL request details page so it
doesn't display 'Unauthenticated ...' more than really needed.

To test:
1. Enable ILLModule
2. Enable ILLOpacUnauthenticatedRequest
3. Set ILLOpacbackends to 'Standard'
4. Make a search in the OPAC (not logged in)
5. At the bottom of the page, follow the 'Make an interlibrary loan
   request' link.
6. Place a request, you are redirected to the request details page
=> FAIL: There are some strings that could go away:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

7. Apply this patch
8. Reload the page
=> SUCCESS: It looks more polished, with no 'Unauthenticated' all over
the place. You still see 'Status: Unauthenticated' anyway
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Pedro Amorim 2025-05-21 12:27:50 UTC
Created attachment 182688 [details] [review]
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

This patch tweaks the unauthenticated ILL request details page so it
doesn't display 'Unauthenticated ...' more than really needed.

To test:
1. Enable ILLModule
2. Enable ILLOpacUnauthenticatedRequest
3. Set ILLOpacbackends to 'Standard'
4. Make a search in the OPAC (not logged in)
5. At the bottom of the page, follow the 'Make an interlibrary loan
   request' link.
6. Place a request, you are redirected to the request details page
=> FAIL: There are some strings that could go away:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

7. Apply this patch
8. Reload the page
=> SUCCESS: It looks more polished, with no 'Unauthenticated' all over
the place. You still see 'Status: Unauthenticated' anyway
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>