There are labels like: * Unauthenticated first name * Unauthenticated last name * Unauthenticated email 'Unauthenticated' feels like an internal thing for staff, and something really weird for an end user to read. It already displays in the 'Status' row.
Created attachment 182681 [details] [review] Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC This patch tweaks the unauthenticated ILL request details page so it doesn't display 'Unauthenticated ...' more than really needed. To test: 1. Enable ILLModule 2. Enable ILLOpacUnauthenticatedRequest 3. Set ILLOpacbackends to 'Standard' 4. Make a search in the OPAC (not logged in) 5. At the bottom of the page, follow the 'Make an interlibrary loan request' link. 6. Place a request, you are redirected to the request details page => FAIL: There are some strings that could go away: * Unauthenticated first name * Unauthenticated last name * Unauthenticated email 7. Apply this patch 8. Reload the page => SUCCESS: It looks more polished, with no 'Unauthenticated' all over the place. You still see 'Status: Unauthenticated' anyway 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 182685 [details] [review] Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC This patch tweaks the unauthenticated ILL request details page so it doesn't display 'Unauthenticated ...' more than really needed. To test: 1. Enable ILLModule 2. Enable ILLOpacUnauthenticatedRequest 3. Set ILLOpacbackends to 'Standard' 4. Make a search in the OPAC (not logged in) 5. At the bottom of the page, follow the 'Make an interlibrary loan request' link. 6. Place a request, you are redirected to the request details page => FAIL: There are some strings that could go away: * Unauthenticated first name * Unauthenticated last name * Unauthenticated email 7. Apply this patch 8. Reload the page => SUCCESS: It looks more polished, with no 'Unauthenticated' all over the place. You still see 'Status: Unauthenticated' anyway 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 182688 [details] [review] Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC This patch tweaks the unauthenticated ILL request details page so it doesn't display 'Unauthenticated ...' more than really needed. To test: 1. Enable ILLModule 2. Enable ILLOpacUnauthenticatedRequest 3. Set ILLOpacbackends to 'Standard' 4. Make a search in the OPAC (not logged in) 5. At the bottom of the page, follow the 'Make an interlibrary loan request' link. 6. Place a request, you are redirected to the request details page => FAIL: There are some strings that could go away: * Unauthenticated first name * Unauthenticated last name * Unauthenticated email 7. Apply this patch 8. Reload the page => SUCCESS: It looks more polished, with no 'Unauthenticated' all over the place. You still see 'Status: Unauthenticated' anyway 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>