Bug 39948 - Simplify unauthenticated ILL request detail in the OPAC
Summary: Simplify unauthenticated ILL request detail in the OPAC
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Pedro Amorim
URL:
Keywords:
Depends on: 36197
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-20 18:18 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-05-21 12:28 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement simplifies the unauthenticated ILL submission detail page for the OPAC. It removes 'Unauthenticated ...' in front og the labels for the first name, last name, and email fields.
Version(s) released in:
Circulation function:


Attachments
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC (2.69 KB, patch)
2025-05-20 18:25 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC (2.73 KB, patch)
2025-05-21 08:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC (2.79 KB, patch)
2025-05-21 12:27 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-05-20 18:18:47 UTC
There are labels like:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

'Unauthenticated' feels like an internal thing for staff, and something really weird for an end user to read. It already displays in the 'Status' row.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-05-20 18:25:31 UTC
Created attachment 182681 [details] [review]
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

This patch tweaks the unauthenticated ILL request details page so it
doesn't display 'Unauthenticated ...' more than really needed.

To test:
1. Enable ILLModule
2. Enable ILLOpacUnauthenticatedRequest
3. Set ILLOpacbackends to 'Standard'
4. Make a search in the OPAC (not logged in)
5. At the bottom of the page, follow the 'Make an interlibrary loan
   request' link.
6. Place a request, you are redirected to the request details page
=> FAIL: There are some strings that could go away:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

7. Apply this patch
8. Reload the page
=> SUCCESS: It looks more polished, with no 'Unauthenticated' all over
the place. You still see 'Status: Unauthenticated' anyway
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2025-05-21 08:13:22 UTC
Created attachment 182685 [details] [review]
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

This patch tweaks the unauthenticated ILL request details page so it
doesn't display 'Unauthenticated ...' more than really needed.

To test:
1. Enable ILLModule
2. Enable ILLOpacUnauthenticatedRequest
3. Set ILLOpacbackends to 'Standard'
4. Make a search in the OPAC (not logged in)
5. At the bottom of the page, follow the 'Make an interlibrary loan
   request' link.
6. Place a request, you are redirected to the request details page
=> FAIL: There are some strings that could go away:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

7. Apply this patch
8. Reload the page
=> SUCCESS: It looks more polished, with no 'Unauthenticated' all over
the place. You still see 'Status: Unauthenticated' anyway
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Pedro Amorim 2025-05-21 12:27:50 UTC
Created attachment 182688 [details] [review]
Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC

This patch tweaks the unauthenticated ILL request details page so it
doesn't display 'Unauthenticated ...' more than really needed.

To test:
1. Enable ILLModule
2. Enable ILLOpacUnauthenticatedRequest
3. Set ILLOpacbackends to 'Standard'
4. Make a search in the OPAC (not logged in)
5. At the bottom of the page, follow the 'Make an interlibrary loan
   request' link.
6. Place a request, you are redirected to the request details page
=> FAIL: There are some strings that could go away:

* Unauthenticated first name
* Unauthenticated last name
* Unauthenticated email

7. Apply this patch
8. Reload the page
=> SUCCESS: It looks more polished, with no 'Unauthenticated' all over
the place. You still see 'Status: Unauthenticated' anyway
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>