Summary: | Recalled status does not show properly on staff interface record detail page | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Circulation | Assignee: | Aleisha Amohia <aleisha> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the holdings table for a record with recalls in the staff interface - it now correctly shows that a recall was placed for record-level and item-level recalls.
Before this change:
- For record-level recalls, the recall status was not shown.
- For item-level recalls, the recall status was shown twice.
|
|
Version(s) released in: | Circulation function: | Recalls | |
Bug Depends on: | 38512 | ||
Bug Blocks: | |||
Attachments: |
Bug 39962: Allocate item to bib-level recall when checkout chosen
Bug 39962: Allocate checkout item to current recalls Bug 39962: Allocate item to bib-level recall when checkout chosen Bug 39962: Allocate checkout item to current recalls |
Description
Aleisha Amohia
2025-05-21 22:18:45 UTC
Looks like this was caused by Bug 38512 - item-level recalls display as expected, but biblio-level recalls don't indicate who the return notice was sent to. Created attachment 182807 [details] [review] Bug 39962: Allocate item to bib-level recall when checkout chosen When a biblio-level recall is requested, the checkout with the oldest due date is chosen to have its due date adjusted and sent a return notice. However the chosen checkout item isn't assigned to the recall. This makes it hard for Koha to know which item to show as 'recalled' on the biblio detail page. This patch allocates the checked out item that gets chosen for the recall by oldest due date, to the recall in the database. This patch then checks if the item has an attached recall to display recall information on the biblio detail page, rather than checking for if the UseRecalls system preference is enabled. To test: 1) Enable the UseRecalls system preference and set recalls-related circulation rules. 2) Find a record with at least one item 3) Check out an item in this record to Patron B 4) Log into the OPAC as Patron A and place a biblio-level recall on the record 5) View the record on the staff interface and look at the holdings table 6) The checked out item should now also show a message that it is recalled. 7) Cancel the recall 8) Go back to the OPAC as Patron A and this time place an item-level recall on the checked out item 9) View the record on the staff interface and confirm the recall message shows as expected 10) Confirm all tests pass t/db_dependent/Koha/Item.t , t/db_dependent/Koha/Recalls.t , t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored-by: Auckland University of Technology Created attachment 182808 [details] [review] Bug 39962: Allocate checkout item to current recalls 1. Set up a recall before applying both of these patches 2. Apply the first patch and notice that the recall still doesn't show, because it was created before the patch was applied 3. Apply this patch, install database updates and restart services 4. Notice your old recall now shows as requested and was allocated the relevant checkout item Sponsored-by: Auckland University of Technology Created attachment 182866 [details] [review] Bug 39962: Allocate item to bib-level recall when checkout chosen When a biblio-level recall is requested, the checkout with the oldest due date is chosen to have its due date adjusted and sent a return notice. However the chosen checkout item isn't assigned to the recall. This makes it hard for Koha to know which item to show as 'recalled' on the biblio detail page. This patch allocates the checked out item that gets chosen for the recall by oldest due date, to the recall in the database. This patch then checks if the item has an attached recall to display recall information on the biblio detail page, rather than checking for if the UseRecalls system preference is enabled. To test: 1) Enable the UseRecalls system preference and set recalls-related circulation rules. 2) Find a record with at least one item 3) Check out an item in this record to Patron B 4) Log into the OPAC as Patron A and place a biblio-level recall on the record 5) View the record on the staff interface and look at the holdings table 6) The checked out item should now also show a message that it is recalled. 7) Cancel the recall 8) Go back to the OPAC as Patron A and this time place an item-level recall on the checked out item 9) View the record on the staff interface and confirm the recall message shows as expected 10) Confirm all tests pass t/db_dependent/Koha/Item.t , t/db_dependent/Koha/Recalls.t , t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Created attachment 182867 [details] [review] Bug 39962: Allocate checkout item to current recalls 1. Set up a recall before applying both of these patches 2. Apply the first patch and notice that the recall still doesn't show, because it was created before the patch was applied 3. Apply this patch, install database updates and restart services 4. Notice your old recall now shows as requested and was allocated the relevant checkout item Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> |