| Summary: | REST API - Creating a patron without mandatory attribute types does not error (it should) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | REST API | Assignee: | Pedro Amorim <pedro.amorim> |
| Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, glasklas, jonathan.druart, katrin.fischer, martin.renvoize, nick, pedro.amorim, tomascohen |
| Version: | Main | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes a regression when creating a patron using the API. No error was returned if mandatory patron attributes were not provided, when it should be.
|
Version(s) released in: |
25.11.00,25.05.01
|
| Circulation function: | |||
| Bug Depends on: | 39334 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 39970: Remove changed_attributes_codes check
Bug 39970: Add tests Bug 39970: Add tests Bug 39970: Remove changed_attributes_codes check Bug 39970: Remove changed_attributes_codes check Bug 39970: Add tests Bug 39970: Remove changed_attributes_codes check |
||
|
Description
Pedro Amorim
2025-05-22 13:42:50 UTC
Created attachment 182731 [details] [review] Bug 39970: Remove changed_attributes_codes check Created attachment 182732 [details] [review] Bug 39970: Add tests Test plan: 1) Apply this test patch. Run. Verify it fails 2) Apply other patch. Run. Verify it passes. prove t/db_dependent/api/v1/patrons.t Verify no other regressions are introduced, run: prove t/db_dependent/Koha/Patron/Attribute.t Created attachment 182736 [details] [review] Bug 39970: Add tests Test plan: 1) Apply this test patch. Run. Verify it fails 2) Apply other patch. Run. Verify it passes. prove t/db_dependent/api/v1/patrons.t Verify no other regressions are introduced, run: prove t/db_dependent/Koha/Patron/Attribute.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 182737 [details] [review] Bug 39970: Remove changed_attributes_codes check Signed-off-by: David Nind <david@davidnind.com> Created attachment 182803 [details] [review] Bug 39970: Remove changed_attributes_codes check Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 182819 [details] [review] Bug 39970: Add tests Test plan: 1) Apply this test patch. Run. Verify it fails 2) Apply other patch. Run. Verify it passes. prove t/db_dependent/api/v1/patrons.t Verify no other regressions are introduced, run: prove t/db_dependent/Koha/Patron/Attribute.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 182820 [details] [review] Bug 39970: Remove changed_attributes_codes check Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 I see in 25.05.x Depends on Bug 39334 not in 24.11.x No changes to the manual required. |