Bug 39970

Summary: REST API - Creating a patron without mandatory attribute types does not error (it should)
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: REST APIAssignee: Pedro Amorim <pedro.amorim>
Status: Needs documenting --- QA Contact: Nick Clemens (kidclamp) <nick>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, glasklas, jonathan.druart, katrin.fischer, martin.renvoize, nick, pedro.amorim, tomascohen
Version: MainKeywords: regression
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.01
Circulation function:
Bug Depends on: 39334    
Bug Blocks:    
Attachments: Bug 39970: Remove changed_attributes_codes check
Bug 39970: Add tests
Bug 39970: Add tests
Bug 39970: Remove changed_attributes_codes check
Bug 39970: Remove changed_attributes_codes check
Bug 39970: Add tests
Bug 39970: Remove changed_attributes_codes check

Description Pedro Amorim 2025-05-22 13:42:50 UTC

    
Comment 1 Pedro Amorim 2025-05-22 13:47:56 UTC
Created attachment 182731 [details] [review]
Bug 39970: Remove changed_attributes_codes check
Comment 2 Pedro Amorim 2025-05-22 13:48:00 UTC
Created attachment 182732 [details] [review]
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t
Comment 3 David Nind 2025-05-22 15:06:21 UTC
Created attachment 182736 [details] [review]
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-05-22 15:06:24 UTC
Created attachment 182737 [details] [review]
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Nick Clemens (kidclamp) 2025-05-27 16:19:39 UTC
Created attachment 182803 [details] [review]
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens (kidclamp) 2025-05-28 12:14:07 UTC
Created attachment 182819 [details] [review]
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2025-05-28 12:14:09 UTC
Created attachment 182820 [details] [review]
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2025-06-02 21:27:54 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 9 Fridolin Somers 2025-06-19 07:32:26 UTC
I see in 25.05.x
Comment 10 Fridolin Somers 2025-06-19 07:32:45 UTC
Depends on Bug 39334 not in 24.11.x