Summary: | Show that a patron is the anonymous in patrons search | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Patrons | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This enhancement highlights the anonymous patron using a yellow badge in patron search results (set using the AnonymousPatron system preference).
|
|
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 40000: Show that a patron is the anonymous in patrons search
Screenshot with patch Bug 40000: Show that a patron is the anonymous in patrons search Bug 40000: (follow-up) Use badge to highlight anonymous patron Screenshot - using a badge |
Description
Fridolin Somers
2025-05-26 15:12:30 UTC
Created attachment 183063 [details] [review] Bug 40000: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron Created attachment 183064 [details]
Screenshot with patch
Screenshot with patch on koha-testing-docker
> Display uses class 'circ-hlt' to show bold red text.
Maybe there is a better way for that.
Its is open to discussion ;)
Created attachment 183256 [details] [review] Bug 40000: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron Signed-off-by: David Nind <david@davidnind.com> (In reply to Fridolin Somers from comment #3) > > Display uses class 'circ-hlt' to show bold red text. > Maybe there is a better way for that. > Its is open to discussion ;) Maybe an option is a green badge like the one used to show the default SMTP server (Koha administration > Additional parameters > SMTP servers: add a new server and set as default, in the 'Is default' column there is a green badge with 'Default'). This was added in Bug 37311. So maybe 'Anonymous patron' as a green badge. Created attachment 183258 [details] [review] Bug 40000: (follow-up) Use badge to highlight anonymous patron I think a "warning" class is appropriate because we're warning the user that this patron should be treated differently. I trimmed to label to "Anonymous patron" because I don't think the "This is the..." is necessary for a label. (In reply to David Nind from comment #5) > So maybe 'Anonymous patron' as a green badge. I have attached an opinionated suggestion! (In reply to Owen Leonard from comment #7) > (In reply to David Nind from comment #5) > > So maybe 'Anonymous patron' as a green badge. > > I have attached an opinionated suggestion! Looks great to me Owen! Created attachment 183263 [details]
Screenshot - using a badge
Screenshot showing Owen's alternative patch that uses a yellow badge to highlight the anonymous patron (for the AnonymousPatron system preference).
Ohhh very nice with badge This feature is new to me : https://getbootstrap.com/docs/4.0/components/badge/ (In reply to Fridolin Somers from comment #10) > https://getbootstrap.com/docs/4.0/components/badge/ Not that version! This one: https://getbootstrap.com/docs/5.3/components/badge/ |