Bug 40025

Summary: Standard ILL requests don't update form when changing type in edit item metadata
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to stable --- QA Contact: Lisette Scheer <lisette>
Severity: normal    
Priority: P5 - low CC: david, lisette, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes editing the item metadata for a standard ILL request. If the type (such as book or journal) is changed, the metadata is now updated for the selected type. Before this, matching metadata was not updated.
Version(s) released in:
25.11.00,25.05.01
Circulation function:
Attachments: Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) Yo
Bug 40025: Fix change type for edit item metadata
Bug 40025: Fix change type for edit item metadata
Bug 40025: Fix change type for edit item metadata

Description Pedro Amorim 2025-05-29 12:33:00 UTC

    
Comment 1 Pedro Amorim 2025-05-29 12:35:02 UTC Comment hidden (obsolete)
Comment 2 Pedro Amorim 2025-05-29 12:35:29 UTC
Created attachment 182835 [details] [review]
Bug 40025: Fix change type for edit item metadata

1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Add a type, a cardnumber '42' and any library. Click 'Make request'.
4) You should now be on the 'Manage request' page. Click 'Edit item metadata'.
5) Change the type. Notice the form doesn't update the fields (as it does when you create a new ILL request).
6) Apply patch. Repeat step 5. Notice the form now updates the fields as it does when you create a new ILL request.
Comment 3 David Nind 2025-05-31 12:41:23 UTC
Created attachment 182878 [details] [review]
Bug 40025: Fix change type for edit item metadata

1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Add a type, a cardnumber '42' and any library. Click 'Make request'.
4) You should now be on the 'Manage request' page. Click 'Edit item metadata'.
5) Change the type. Notice the form doesn't update the fields (as it does when you create a new ILL request).
6) Apply patch. Repeat step 5. Notice the form now updates the fields as it does when you create a new ILL request.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lisette Scheer 2025-06-20 19:29:59 UTC
Created attachment 183402 [details] [review]
Bug 40025: Fix change type for edit item metadata

1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Add a type, a cardnumber '42' and any library. Click 'Make request'.
4) You should now be on the 'Manage request' page. Click 'Edit item metadata'.
5) Change the type. Notice the form doesn't update the fields (as it does when you create a new ILL request).
6) Apply patch. Repeat step 5. Notice the form now updates the fields as it does when you create a new ILL request.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Lisette Scheer 2025-06-20 19:31:27 UTC
Worked great. The only thing I noticed was if you changed from book->journal and then to chapter because you misclicked when you selected journal, the author field is lost, but if you don't save, you can go back and try again so I don't think it's a blocker.
Comment 6 Lucas Gass (lukeg) 2025-06-23 15:53:14 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-06-24 09:31:21 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03