Created attachment 182834 [details] [review] Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) Yo
Created attachment 182835 [details] [review] Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) You should now be on the 'Manage request' page. Click 'Edit item metadata'. 5) Change the type. Notice the form doesn't update the fields (as it does when you create a new ILL request). 6) Apply patch. Repeat step 5. Notice the form now updates the fields as it does when you create a new ILL request.
Created attachment 182878 [details] [review] Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) You should now be on the 'Manage request' page. Click 'Edit item metadata'. 5) Change the type. Notice the form doesn't update the fields (as it does when you create a new ILL request). 6) Apply patch. Repeat step 5. Notice the form now updates the fields as it does when you create a new ILL request. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183402 [details] [review] Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) You should now be on the 'Manage request' page. Click 'Edit item metadata'. 5) Change the type. Notice the form doesn't update the fields (as it does when you create a new ILL request). 6) Apply patch. Repeat step 5. Notice the form now updates the fields as it does when you create a new ILL request. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Worked great. The only thing I noticed was if you changed from book->journal and then to chapter because you misclicked when you selected journal, the author field is lost, but if you don't save, you can go back and try again so I don't think it's a blocker.
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x for 25.05.03