Bug 40058

Summary: Move RevertWaitingStatus to Koha::Hold->revert_waiting()
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Signed Off ---    
Severity: enhancement CC: kyle, tomascohen
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40062
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 40055    
Bug Blocks: 17728    
Attachments: Bug 40058: Add Koha::Hold->revert_waiting()
Bug 40058: Remove RevertWaitingStatus()
Bug 40058: Adjust existing tests
Bug 40058: Add Koha::Hold->revert_waiting()
Bug 40058: Remove RevertWaitingStatus()
Bug 40058: Adjust existing tests

Description Tomás Cohen Arazi (tcohen) 2025-06-03 13:01:30 UTC
This method should be moved to the Koha:: namespace.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-06-03 15:12:15 UTC
Created attachment 182924 [details]
Bug 40058: Add Koha::Hold->revert_waiting()

This patch adds a new method to the `Koha::Hold` class. The method
follows the original implementation in C4::Reserves.

Tests are added to cover all the code paths.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass :-D
3. Sign off :-D
Comment 2 Tomás Cohen Arazi (tcohen) 2025-06-03 15:12:17 UTC
Created attachment 182925 [details]
Bug 40058: Remove RevertWaitingStatus()
Comment 3 Tomás Cohen Arazi (tcohen) 2025-06-03 15:12:20 UTC
Created attachment 182926 [details]
Bug 40058: Adjust existing tests
Comment 4 David Nind 2025-06-04 11:22:36 UTC
Created attachment 182941 [details]
Bug 40058: Add Koha::Hold->revert_waiting()

This patch adds a new method to the `Koha::Hold` class. The method
follows the original implementation in C4::Reserves.

Tests are added to cover all the code paths.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass :-D
3. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-06-04 11:22:38 UTC
Created attachment 182942 [details]
Bug 40058: Remove RevertWaitingStatus()

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-06-04 11:22:41 UTC
Created attachment 182943 [details]
Bug 40058: Adjust existing tests

Signed-off-by: David Nind <david@davidnind.com>