Bug 40058 - Move RevertWaitingStatus to Koha::Hold->revert_waiting()
Summary: Move RevertWaitingStatus to Koha::Hold->revert_waiting()
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 40055
Blocks: 17728
  Show dependency treegraph
 
Reported: 2025-06-03 13:01 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-06-06 18:23 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40058: Add Koha::Hold->revert_waiting() (11.50 KB, patch)
2025-06-03 15:12 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40058: Remove RevertWaitingStatus() (5.98 KB, patch)
2025-06-03 15:12 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40058: Adjust existing tests (12.97 KB, patch)
2025-06-03 15:12 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40058: Add Koha::Hold->revert_waiting() (11.54 KB, patch)
2025-06-04 11:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 40058: Remove RevertWaitingStatus() (6.03 KB, patch)
2025-06-04 11:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 40058: Adjust existing tests (13.01 KB, patch)
2025-06-04 11:22 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-06-03 13:01:30 UTC
This method should be moved to the Koha:: namespace.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-06-03 15:12:15 UTC
Created attachment 182924 [details] [review]
Bug 40058: Add Koha::Hold->revert_waiting()

This patch adds a new method to the `Koha::Hold` class. The method
follows the original implementation in C4::Reserves.

Tests are added to cover all the code paths.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass :-D
3. Sign off :-D
Comment 2 Tomás Cohen Arazi (tcohen) 2025-06-03 15:12:17 UTC
Created attachment 182925 [details] [review]
Bug 40058: Remove RevertWaitingStatus()
Comment 3 Tomás Cohen Arazi (tcohen) 2025-06-03 15:12:20 UTC
Created attachment 182926 [details] [review]
Bug 40058: Adjust existing tests
Comment 4 David Nind 2025-06-04 11:22:36 UTC
Created attachment 182941 [details] [review]
Bug 40058: Add Koha::Hold->revert_waiting()

This patch adds a new method to the `Koha::Hold` class. The method
follows the original implementation in C4::Reserves.

Tests are added to cover all the code paths.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass :-D
3. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-06-04 11:22:38 UTC
Created attachment 182942 [details] [review]
Bug 40058: Remove RevertWaitingStatus()

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-06-04 11:22:41 UTC
Created attachment 182943 [details] [review]
Bug 40058: Adjust existing tests

Signed-off-by: David Nind <david@davidnind.com>