| Summary: | Advanced editor should not create empty fields and subfields | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
| Component: | Cataloging | Assignee: | Janusz Kaczmarek <januszop> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, wojciech.baran |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.03,24.11.09
|
|
| Circulation function: | |||
| Attachments: |
Bug 40156: Advanced editor should not create empty fields and subfields
Bug 40156: Advanced editor should not create empty fields and subfields Bug 40156: Advanced editor should not create empty fields and subfields |
||
|
Description
Janusz Kaczmarek
2025-06-17 10:38:50 UTC
Created attachment 183301 [details] [review] Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow Created attachment 183309 [details] [review] Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Wojciech Baran <wojciech.baran@ignatianum.edu.pl> Created attachment 184977 [details] [review] Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Wojciech Baran <wojciech.baran@ignatianum.edu.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.09 |