Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). To reproduce: 1. Enable EnableAdvancedCatalogingEditor. 2. Open a record in the advanced editor, create empty subfield and empty fields, i.e.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong.
Created attachment 183301 [details] [review] Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow
Created attachment 183309 [details] [review] Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Wojciech Baran <wojciech.baran@ignatianum.edu.pl>