Summary: | Incomplete logic for controlling display of OPAC language footer | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Accessibility | Assignee: | Owen Leonard <oleonard> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, matt.blenkinsop, nina.martinez, oleonard, roman.dolny, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 39890 | ||
Attachments: |
Bug 40165: Incomplete logic for controlling display of OPAC language footer
Bug 40165: Incomplete logic for controlling display of OPAC language footer |
Description
Owen Leonard
2025-06-18 16:54:33 UTC
Created attachment 183345 [details] [review] Bug 40165: Incomplete logic for controlling display of OPAC language footer This patch adds some additional logic to the template which controls the appearance of the footer in the OPAC. Some additional checks are required to make sure an empty footer doesn't display in some circumstances. To test, apply the patch and install at least one additional translation besides English. Check any OPAC page when various combinations of system preferences are enabled: - opaclanguagesdisplay - OPACLanguages - OpacLangSelectorMode - OPACReportProblem - CookieConsent - OpacKohaUurl In particular, confirm that there is not an empty footer when opaclanguagesdisplay is enabled but there is only one translation enabled. Sponsored-by: Athens County Public Libraries It works as described for "en". Empty footer is not shown when opaclanguagesdisplay is on, OpacLangSelectorMode both/footer, CookieConsent off, OpacKohaUrl off, OPACLanguages has "en" checked ("pl-PL" not checked). Changing selection in OPACLanguages spoils performance. When in OPACLanguages "pl-PL" is checked and "en" not checked then empty footer appears. Did you update the pl-PL templates after applying the patch? I should have included it in the test plan: gulp po:update --lang pl-PL perl misc/translator/translate install pl-PL Otherwise the changes in the English templates don't get copied over to your translated templates. (In reply to Owen Leonard from comment #3) > Did you update the pl-PL templates after applying the patch? I should have > included it in the test plan: > ... No, I didn't update templates. Thank you for hint. Now it is correct. Created attachment 183409 [details] [review] Bug 40165: Incomplete logic for controlling display of OPAC language footer This patch adds some additional logic to the template which controls the appearance of the footer in the OPAC. Some additional checks are required to make sure an empty footer doesn't display in some circumstances. To test, apply the patch and install at least one additional translation besides English. Check any OPAC page when various combinations of system preferences are enabled: - opaclanguagesdisplay - OPACLanguages - OpacLangSelectorMode - OPACReportProblem - CookieConsent - OpacKohaUurl In particular, confirm that there is not an empty footer when opaclanguagesdisplay is enabled but there is only one translation enabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |