Summary: | Tidy `build-git-snapshot` | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | Signed Off --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | flaterdavid, jonathan.druart, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 38664, 40039 | ||
Bug Blocks: | 39876 | ||
Attachments: |
Bug 40261: Teach tidy.pl how to handle build-git-snapshot
Bug 40261: Teach tidy.pl how to handle build-git-snapshot Bug 40261: Tidy debian/build-git-snapshot Bug 40261: Tidy debian/build-git-snapshot Bug 40261: Teach tidy.pl how to handle build-git-snapshot Bug 40261: Tidy debian/build-git-snapshot |
Description
Tomás Cohen Arazi (tcohen)
2025-06-27 13:58:14 UTC
Created attachment 183608 [details] [review] Bug 40261: Teach tidy.pl how to handle build-git-snapshot This patch makes the `tidy.pl` script handle the mentioned script as a Perl script. To test: 1. Run: $ ktd --shell k$ perl misc/devel/tidy.pl debian/build-git-snapshot => FAIL: You get: ``` Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: It tidies the file! 4. Reset to the current head k$ git reset --hard HEAD 5. Apply the tidy patch 6. Repeat 1 7. Run: k$ git diff => SUCCESS: No diff, the file is tidy 8. Sign off :-D Created attachment 183610 [details] [review] Bug 40261: Teach tidy.pl how to handle build-git-snapshot This patch makes the `tidy.pl` script handle the mentioned script as a Perl script. To test: 1. Run: $ ktd --shell k$ perl misc/devel/tidy.pl debian/build-git-snapshot => FAIL: You get: ``` Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: It tidies the file! 4. Reset to the current head k$ git reset --hard HEAD 5. Apply the tidy patch 6. Repeat 1 7. Run: k$ git diff => SUCCESS: No diff, the file is tidy 8. Sign off :-D Created attachment 183611 [details] [review] Bug 40261: Tidy debian/build-git-snapshot Created attachment 183612 [details] [review] Bug 40261: Tidy debian/build-git-snapshot Signed-off-by: David Flater <flaterdavid@gmail.com> Created attachment 183613 [details] [review] Bug 40261: Teach tidy.pl how to handle build-git-snapshot This patch makes the `tidy.pl` script handle the mentioned script as a Perl script. To test: 1. Run: $ ktd --shell k$ perl misc/devel/tidy.pl debian/build-git-snapshot => FAIL: You get: ``` Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: It tidies the file! 4. Reset to the current head k$ git reset --hard HEAD 5. Apply the tidy patch 6. Repeat 1 7. Run: k$ git diff => SUCCESS: No diff, the file is tidy 8. Sign off :-D Created attachment 183614 [details] [review] Bug 40261: Tidy debian/build-git-snapshot Signed-off-by: David Flater <flaterdavid@gmail.com> (In reply to Jonathan Druart from comment #7) > Will conflict with bug 39876... Moved my change to that bug. And PQA it :-D I moved the logic change into 39876. Keeping the tidy here. |