Bug 40286

Summary: Make C4::Auth::checkpw_internal use Koha::Patrons->find_by_identifier
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 33905, 40275    
Bug Blocks:    

Description Tomás Cohen Arazi (tcohen) 2025-07-01 15:05:21 UTC
Bug 40275 introduced this method and this is the missing place for refactoring.

The current tests for this method include the creation of actually conflicting patrons, matching their userid and cardnumber respectively. As making the proposed change is indeed a behavior change, I file this report in order to discuss how to handle it properly. The other use cases are clear and already covered in bug 40275.

The blocker for this is bug 33905, in which we need to decide how to ensure identifier uniqueness, and then get rid of the tests.