Bug 40286 - Make C4::Auth::checkpw_internal use Koha::Patrons->find_by_identifier
Summary: Make C4::Auth::checkpw_internal use Koha::Patrons->find_by_identifier
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 33905 40275
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-01 15:05 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-07-01 15:05 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-07-01 15:05:21 UTC
Bug 40275 introduced this method and this is the missing place for refactoring.

The current tests for this method include the creation of actually conflicting patrons, matching their userid and cardnumber respectively. As making the proposed change is indeed a behavior change, I file this report in order to discuss how to handle it properly. The other use cases are clear and already covered in bug 40275.

The blocker for this is bug 33905, in which we need to decide how to ensure identifier uniqueness, and then get rid of the tests.