Bug 40347

Summary: Koha/Hold.t generates diag
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 25515    
Attachments: Bug 40347: Remove warnings from Koha/Hold.t
Bug 40347: Remove warnings from Koha/Hold.t

Description Jonathan Druart 2025-07-11 12:31:55 UTC
They are not warnings but we don't really need them in the output
        # Filling a hold when pref enabled should trigger a test
        # Filling a hold when pref disabled should not trigger a test
        # Updating a hold location when pref disabled should not trigger a test
        # Updating a hold location when pref enabled should trigger a test
        # Update with no change to pickup location should not trigger a test
Comment 1 Jonathan Druart 2025-07-11 12:36:48 UTC
Created attachment 183990 [details] [review]
Bug 40347: Remove warnings from Koha/Hold.t

Those diag statements are not really needed

    # Filling a hold when pref enabled should trigger a test
    # Filling a hold when pref disabled should not trigger a test
    # Updating a hold location when pref disabled should not trigger a test
    # Updating a hold location when pref enabled should trigger a test
    # Update with no change to pickup location should not trigger a test
Comment 2 Martin Renvoize (ashimema) 2025-07-12 10:06:40 UTC
Created attachment 184025 [details] [review]
Bug 40347: Remove warnings from Koha/Hold.t

Those diag statements are not really needed

    # Filling a hold when pref enabled should trigger a test
    # Filling a hold when pref disabled should not trigger a test
    # Updating a hold location when pref disabled should not trigger a test
    # Updating a hold location when pref enabled should trigger a test
    # Update with no change to pickup location should not trigger a test

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 3 Lucas Gass (lukeg) 2025-07-15 22:35:04 UTC
Nice work everyone!

Pushed to main for 25.11