Summary: | t/db_dependent/Holds.t generates warnings | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 25515 | ||
Attachments: |
Bug 40350: Remove warnings from t/db_dependent/Holds.t
Bug 40350: Remove warnings from t/db_dependent/Holds.t |
Description
Jonathan Druart
2025-07-11 12:40:16 UTC
Created attachment 183991 [details] [review] Bug 40350: Remove warnings from t/db_dependent/Holds.t Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3151. Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Circulation.pm line 3158. Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3151. Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Circulation.pm line 3158. Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3151. Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Circulation.pm line 3158. $issue->renewal_count is undefined in C4::Circulation:3151, but it's NOT NULL in DB We need to refetch the row to get the default defined at the DB level Created attachment 184027 [details] [review] Bug 40350: Remove warnings from t/db_dependent/Holds.t Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3151. Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Circulation.pm line 3158. Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3151. Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Circulation.pm line 3158. Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3151. Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Circulation.pm line 3158. $issue->renewal_count is undefined in C4::Circulation:3151, but it's NOT NULL in DB We need to refetch the row to get the default defined at the DB level Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 |