Summary: | t/db_dependent/Budgets.t generates warnings | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 25515 | ||
Attachments: |
Bug 40371: Remove warnings from Budgets.t output
Bug 40371: Remove warnings from Budgets.t output |
Description
Jonathan Druart
2025-07-15 08:58:32 UTC
Created attachment 184074 [details] [review] Bug 40371: Remove warnings from Budgets.t output t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 543. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 554. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 543. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 554. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 510. This change seems correct, but I am not 100% sure it won't introduce a regression. What about 0 vs undef? Nick, do you think this change is safe? Created attachment 184126 [details] [review] Bug 40371: Remove warnings from Budgets.t output t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 543. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 554. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 543. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 554. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 510. This change seems correct, but I am not 100% sure it won't introduce a regression. What about 0 vs undef? Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> I agree with your comment there.. we might have a problem with 0 vs NULL. However, I can't spot any obvious regressions.. I feel perhaps we should go with this and carefully monitor. |