Bug 40410

Summary: Letters.t generates a warning
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to oldstable --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:
Bug Depends on:    
Bug Blocks: 40444    
Attachments: Bug 40410: Remove warning from Letters.
Bug 40410: Remove warning from Letters.
Bug 40410: Remove warning from Letters.

Description Jonathan Druart 2025-07-16 10:39:07 UTC
t/db_dependent/Letters.t .. 95/104 Use of uninitialized value in string eq at /kohadevbox/koha/Koha/Patron.pm line 389.
Comment 1 Jonathan Druart 2025-07-16 10:40:02 UTC
Created attachment 184144 [details] [review]
Bug 40410: Remove warning from Letters.

t/db_dependent/Letters.t .. 95/104 Use of uninitialized value in string eq at /kohadevbox/koha/Koha/Patron.pm line 389.

contactname can be NULL in DB.
Comment 2 David Nind 2025-07-18 09:30:53 UTC
Created attachment 184314 [details] [review]
Bug 40410: Remove warning from Letters.

t/db_dependent/Letters.t .. 95/104 Use of uninitialized value in string eq at /kohadevbox/koha/Koha/Patron.pm line 389.

contactname can be NULL in DB.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2025-07-18 12:17:17 UTC
Created attachment 184368 [details] [review]
Bug 40410: Remove warning from Letters.

t/db_dependent/Letters.t .. 95/104 Use of uninitialized value in string eq at /kohadevbox/koha/Koha/Patron.pm line 389.

contactname can be NULL in DB.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Lucas Gass (lukeg) 2025-07-18 17:12:53 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-07-24 08:21:38 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-08-01 13:13:45 UTC
Pushed to 24.11.x for 24.11.08