Summary: | Mark as lost and notify patron is broken in pendingreserves.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Component: | Hold requests | Assignee: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | flaterdavid, gmcharlt, lisette, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Attachments: |
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Bug 40515: Fix regexp for cud-mark_as_lost_and_notify |
Description
Baptiste Wojtkowski (bwoj)
2025-07-25 12:49:04 UTC
Created attachment 184627 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Created attachment 185103 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Signed-off-by: David Flater <flaterdavid@gmail.com> Git grep circ/pendingreserves.pl:} elsif ( $op =~ m|mark_as_lost| ) { circ/pendingreserves.pl: if ( $op eq 'cud-mark_as_lost_and_notify' koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt: <input type="hidden" name="op" value="cud-mark_as_lost" /> koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt: <input type="hidden" name="op" value="cud-mark_as_lost_and_notify" /> Instead of a partial test on mark_as_lost we should include the cud part here and either keep a regex or just specify the two choices possible. Created attachment 185313 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Created attachment 185892 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 |