Steps to reproduce: 1 - Have a new reserve for an available item. 2 - Go on "Holds to pull" 3 - Click on the button "Mark as lost and notify patron" -> Nothing happens
Created attachment 184627 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify
Created attachment 185103 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Signed-off-by: David Flater <flaterdavid@gmail.com>
Git grep circ/pendingreserves.pl:} elsif ( $op =~ m|mark_as_lost| ) { circ/pendingreserves.pl: if ( $op eq 'cud-mark_as_lost_and_notify' koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt: <input type="hidden" name="op" value="cud-mark_as_lost" /> koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt: <input type="hidden" name="op" value="cud-mark_as_lost_and_notify" /> Instead of a partial test on mark_as_lost we should include the cud part here and either keep a regex or just specify the two choices possible.
Created attachment 185313 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify
Created attachment 185892 [details] [review] Bug 40515: Fix regexp for cud-mark_as_lost_and_notify Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 25.11