Bug 40515 - Mark as lost and notify patron is broken in pendingreserves.pl
Summary: Mark as lost and notify patron is broken in pendingreserves.pl
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-25 12:49 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-08-29 17:10 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify (993 bytes, patch)
2025-07-25 12:52 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify (1.02 KB, patch)
2025-08-04 14:35 UTC, David Flater
Details | Diff | Splinter Review
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify (1.27 KB, patch)
2025-08-12 10:41 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify (1.16 KB, patch)
2025-08-29 09:46 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-07-25 12:49:04 UTC
Steps to reproduce:
1 - Have a new reserve for an available item.
2 - Go on "Holds to pull"
3 - Click on the button "Mark as lost and notify patron" -> Nothing happens
Comment 1 Baptiste Wojtkowski (bwoj) 2025-07-25 12:52:54 UTC
Created attachment 184627 [details] [review]
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify
Comment 2 David Flater 2025-08-04 14:35:30 UTC
Created attachment 185103 [details] [review]
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify

Signed-off-by: David Flater <flaterdavid@gmail.com>
Comment 3 Marcel de Rooy 2025-08-08 09:19:42 UTC
Git grep

circ/pendingreserves.pl:} elsif ( $op =~ m|mark_as_lost| ) {
circ/pendingreserves.pl:        if ( $op eq 'cud-mark_as_lost_and_notify'
koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt:                                                            <input type="hidden" name="op" value="cud-mark_as_lost" />
koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt:                                                            <input type="hidden" name="op" value="cud-mark_as_lost_and_notify" />

Instead of a partial test on mark_as_lost we should include the cud part here and either keep a regex or just specify the two choices possible.
Comment 4 Baptiste Wojtkowski (bwoj) 2025-08-12 10:41:20 UTC
Created attachment 185313 [details] [review]
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify
Comment 5 Marcel de Rooy 2025-08-29 09:46:17 UTC
Created attachment 185892 [details] [review]
Bug 40515: Fix regexp for cud-mark_as_lost_and_notify

Signed-off-by: David Flater <flaterdavid@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Lucas Gass (lukeg) 2025-08-29 17:10:17 UTC
Nice work everyone!

Pushed to main for 25.11