Bug 40516

Summary: Boolean filters are broken on datatables
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: Architecture, internals, and plumbingAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Passed QA --- QA Contact: Laura Escamilla <Laura.escamilla>
Severity: normal    
Priority: P5 - low CC: Laura.escamilla, pedro.amorim
Version: MainKeywords: rel_24_11_candidate, rel_25_05_candidate
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 40118    
Bug Blocks:    
Attachments: Bug 40516: Restore falsy boolean filter values
Bug 40516: Restore falsy boolean filter values
Bug 40516: Restore falsy boolean filter values

Description Matt Blenkinsop 2025-07-25 13:35:44 UTC
Datatable filters that are boolean based are no longer displaying the falsy option and are filtering incorrectly
Comment 1 Matt Blenkinsop 2025-07-25 13:39:46 UTC
Created attachment 184628 [details] [review]
Bug 40516: Restore falsy boolean filter values

Test plan:
1) Navigate to ERM agreements and create an agreement
2) In the agreements table, click on the filter for Is Perpetual
3) Only the option for 'Yes' will be shown
4) Apply patch
5) yarn js:build
6) Hard refresh the browser and repeat step 2
7) Filter options for Yes and No should be available
8) Check the filtering works appropriately
Comment 2 Pedro Amorim 2025-07-25 13:52:36 UTC
Created attachment 184636 [details] [review]
Bug 40516: Restore falsy boolean filter values

Test plan:
1) Navigate to ERM agreements and create an agreement
2) In the agreements table, click on the filter for Is Perpetual
3) Only the option for 'Yes' will be shown
4) Apply patch
5) yarn js:build
6) Hard refresh the browser and repeat step 2
7) Filter options for Yes and No should be available
8) Check the filtering works appropriately

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 3 Laura Escamilla 2025-07-25 21:08:57 UTC
Created attachment 184677 [details] [review]
Bug 40516: Restore falsy boolean filter values

Works great! 

Test plan:
1) Navigate to ERM agreements and create an agreement
2) In the agreements table, click on the filter for Is Perpetual
3) Only the option for 'Yes' will be shown
4) Apply patch
5) yarn js:build
6) Hard refresh the browser and repeat step 2
7) Filter options for Yes and No should be available
8) Check the filtering works appropriately

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>