Bug 40516 - Boolean filters are broken on datatables
Summary: Boolean filters are broken on datatables
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Matt Blenkinsop
QA Contact: Laura Escamilla
URL:
Keywords: rel_24_11_candidate, rel_25_05_candidate
Depends on: 40118
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-25 13:35 UTC by Matt Blenkinsop
Modified: 2025-07-25 21:09 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40516: Restore falsy boolean filter values (1.34 KB, patch)
2025-07-25 13:39 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 40516: Restore falsy boolean filter values (1.39 KB, patch)
2025-07-25 13:52 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40516: Restore falsy boolean filter values (1.46 KB, patch)
2025-07-25 21:08 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-07-25 13:35:44 UTC
Datatable filters that are boolean based are no longer displaying the falsy option and are filtering incorrectly
Comment 1 Matt Blenkinsop 2025-07-25 13:39:46 UTC
Created attachment 184628 [details] [review]
Bug 40516: Restore falsy boolean filter values

Test plan:
1) Navigate to ERM agreements and create an agreement
2) In the agreements table, click on the filter for Is Perpetual
3) Only the option for 'Yes' will be shown
4) Apply patch
5) yarn js:build
6) Hard refresh the browser and repeat step 2
7) Filter options for Yes and No should be available
8) Check the filtering works appropriately
Comment 2 Pedro Amorim 2025-07-25 13:52:36 UTC
Created attachment 184636 [details] [review]
Bug 40516: Restore falsy boolean filter values

Test plan:
1) Navigate to ERM agreements and create an agreement
2) In the agreements table, click on the filter for Is Perpetual
3) Only the option for 'Yes' will be shown
4) Apply patch
5) yarn js:build
6) Hard refresh the browser and repeat step 2
7) Filter options for Yes and No should be available
8) Check the filtering works appropriately

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 3 Laura Escamilla 2025-07-25 21:08:57 UTC
Created attachment 184677 [details] [review]
Bug 40516: Restore falsy boolean filter values

Works great! 

Test plan:
1) Navigate to ERM agreements and create an agreement
2) In the agreements table, click on the filter for Is Perpetual
3) Only the option for 'Yes' will be shown
4) Apply patch
5) yarn js:build
6) Hard refresh the browser and repeat step 2
7) Filter options for Yes and No should be available
8) Check the filtering works appropriately

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>