Bug 40523

Summary: Remove unused export_buttons variable from koha-tmpl/opac-tmpl/bootstrap/js/datatables.js
Product: Koha Reporter: David Cook <dcook>
Component: OPACAssignee: David Cook <dcook>
Status: Needs documenting --- QA Contact: Jonathan Druart <jonathan.druart>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:
Attachments: Bug 40523: Remove unused variable from datatables.js
Bug 40523: Remove unused variable from datatables.js
Bug 40523: Remove unused variable from datatables.js

Description David Cook 2025-07-28 00:43:25 UTC
There is an "export_buttons" data structure and a "buttons" data structure. The former isn't used anymore. The latter is what is used.

It looks like we can just remove "export_buttons" completely.
Comment 1 David Cook 2025-07-28 04:06:25 UTC
Created attachment 184700 [details] [review]
Bug 40523: Remove unused variable from datatables.js

This change removes an unused variable from datatables.js

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl
2. Search for this payload: "abc123"
3. Click on "Search history" in the top right corner of the screen
4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar
5. Note that all the buttons work as expected
Comment 2 Owen Leonard 2025-07-29 12:04:09 UTC
Created attachment 184795 [details] [review]
Bug 40523: Remove unused variable from datatables.js

This change removes an unused variable from datatables.js

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl
2. Search for this payload: "abc123"
3. Click on "Search history" in the top right corner of the screen
4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar
5. Note that all the buttons work as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2025-09-15 13:57:49 UTC
Created attachment 186403 [details] [review]
Bug 40523: Remove unused variable from datatables.js

This change removes an unused variable from datatables.js

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl
2. Search for this payload: "abc123"
3. Click on "Search history" in the top right corner of the screen
4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar
5. Note that all the buttons work as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Lucas Gass (lukeg) 2025-09-18 19:54:08 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-09-25 16:30:09 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-10-16 05:56:58 UTC
Not pushed to 24.11.x