There is an "export_buttons" data structure and a "buttons" data structure. The former isn't used anymore. The latter is what is used. It looks like we can just remove "export_buttons" completely.
Created attachment 184700 [details] [review] Bug 40523: Remove unused variable from datatables.js This change removes an unused variable from datatables.js Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Search for this payload: "abc123" 3. Click on "Search history" in the top right corner of the screen 4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar 5. Note that all the buttons work as expected
Created attachment 184795 [details] [review] Bug 40523: Remove unused variable from datatables.js This change removes an unused variable from datatables.js Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Search for this payload: "abc123" 3. Click on "Search history" in the top right corner of the screen 4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar 5. Note that all the buttons work as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 186403 [details] [review] Bug 40523: Remove unused variable from datatables.js This change removes an unused variable from datatables.js Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Search for this payload: "abc123" 3. Click on "Search history" in the top right corner of the screen 4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar 5. Note that all the buttons work as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x