Bug 40523 - Remove unused export_buttons variable from koha-tmpl/opac-tmpl/bootstrap/js/datatables.js
Summary: Remove unused export_buttons variable from koha-tmpl/opac-tmpl/bootstrap/js/d...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-28 00:43 UTC by David Cook
Modified: 2025-07-29 12:04 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40523: Remove unused variable from datatables.js (1.82 KB, patch)
2025-07-28 04:06 UTC, David Cook
Details | Diff | Splinter Review
Bug 40523: Remove unused variable from datatables.js (1.87 KB, patch)
2025-07-29 12:04 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2025-07-28 00:43:25 UTC
There is an "export_buttons" data structure and a "buttons" data structure. The former isn't used anymore. The latter is what is used.

It looks like we can just remove "export_buttons" completely.
Comment 1 David Cook 2025-07-28 04:06:25 UTC
Created attachment 184700 [details] [review]
Bug 40523: Remove unused variable from datatables.js

This change removes an unused variable from datatables.js

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl
2. Search for this payload: "abc123"
3. Click on "Search history" in the top right corner of the screen
4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar
5. Note that all the buttons work as expected
Comment 2 Owen Leonard 2025-07-29 12:04:09 UTC
Created attachment 184795 [details] [review]
Bug 40523: Remove unused variable from datatables.js

This change removes an unused variable from datatables.js

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl
2. Search for this payload: "abc123"
3. Click on "Search history" in the top right corner of the screen
4. Click ""CSV", "Copy", and "Print" on the "Current session" toolbar
5. Note that all the buttons work as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>